Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/fxcrt/fx_basic_maps.cpp

Issue 2032613003: Get rid of NULLs in core/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Git rid of comparisons against NULL Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/fxcodec/lgif/fx_gif.cpp ('K') | « core/fxcodec/lgif/fx_gif.cpp ('k') | core/fxcrt/fxcrt_windows.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxcrt/fx_basic_maps.cpp
diff --git a/core/fxcrt/fx_basic_maps.cpp b/core/fxcrt/fx_basic_maps.cpp
index dda8167bdba572721f0ef4ddd28e9cc168fef61c..40f4cf62c6be2148c3e440291b0bb4ed4fec47ed 100644
--- a/core/fxcrt/fx_basic_maps.cpp
+++ b/core/fxcrt/fx_basic_maps.cpp
@@ -77,10 +77,9 @@ void* CFX_MapPtrToPtr::GetValueAt(void* key) const {
void*& CFX_MapPtrToPtr::operator[](void* key) {
uint32_t nHash;
CAssoc* pAssoc;
- if ((pAssoc = GetAssocAt(key, nHash)) == NULL) {
- if (!m_pHashTable) {
+ if (!(pAssoc = GetAssocAt(key, nHash))) {
Tom Sepez 2016/06/02 20:09:48 nit: move assign to previous line.
Lei Zhang 2016/06/07 07:33:23 I did in a later CL.
+ if (!m_pHashTable)
InitHashTable(m_nHashTableSize);
- }
pAssoc = NewAssoc();
pAssoc->key = key;
pAssoc->pNext = m_pHashTable[nHash];
« core/fxcodec/lgif/fx_gif.cpp ('K') | « core/fxcodec/lgif/fx_gif.cpp ('k') | core/fxcrt/fxcrt_windows.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698