Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2032613002: Converts RootWindowLayoutManager to common types (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts RootWindowLayoutManager to common types RootWindowLayoutManager was calling into the background, I changed the background to listen for bounds changes on the parent, which makes more sense. BUG=none TEST=none Committed: https://crrev.com/7cd30704baf1b5f83f8514f46da9759e36349195 Cr-Commit-Position: refs/heads/master@{#397242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -98 lines) Patch
M ash/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_widget_controller.h View 4 chunks +18 lines, -5 lines 0 comments Download
M ash/desktop_background/desktop_background_widget_controller.cc View 3 chunks +30 lines, -7 lines 0 comments Download
M ash/root_window_controller.h View 3 chunks +0 lines, -5 lines 0 comments Download
M ash/root_window_controller.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ash/root_window_controller_common.h View 2 chunks +10 lines, -0 lines 0 comments Download
M ash/root_window_controller_common.cc View 3 chunks +8 lines, -1 line 0 comments Download
M ash/shell.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/shell_test_api.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/test/shell_test_api.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/root_window_layout_manager.h View 1 chunk +13 lines, -26 lines 0 comments Download
M ash/wm/root_window_layout_manager.cc View 1 chunk +18 lines, -41 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
sky
4 years, 6 months ago (2016-06-01 18:24:48 UTC) #3
James Cook
lgtm
4 years, 6 months ago (2016-06-01 20:50:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032613002/1
4 years, 6 months ago (2016-06-01 20:52:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 21:11:04 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 21:15:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cd30704baf1b5f83f8514f46da9759e36349195
Cr-Commit-Position: refs/heads/master@{#397242}

Powered by Google App Engine
This is Rietveld 408576698