Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2025413002: Moves RootWindowControllerCommon and LayoutManager to common (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
Reviewers:
James Cook, reveman
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@use_root_window_controller_common
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves RootWindowControllerCommon and LayoutManager to common I would have done with the last patch, but git wasn't picking up the move correctly. BUG=none TEST=none R=jamescook@chromium.org TBR=reveman@chromium.org Committed: https://crrev.com/c096d9f102cb50ec1c5290ad5ef52636b4b4487e Cr-Commit-Position: refs/heads/master@{#397384}

Patch Set 1 #

Patch Set 2 : move shell_window_ids #

Patch Set 3 : similarity=20 #

Patch Set 4 : similarity=30 #

Patch Set 5 : add back static_assert #

Total comments: 2

Patch Set 6 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -821 lines) Patch
M ash/DEPS View 1 1 chunk +0 lines, -9 lines 0 comments Download
M ash/accelerators/accelerator_controller.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_filter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/exit_warning_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/app_list/app_list_presenter_delegate_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 1 5 chunks +5 lines, -5 lines 0 comments Download
A + ash/common/root_window_controller_common.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/root_window_controller_common.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + ash/common/shell_window_ids.h View 1 2 3 4 6 chunks +32 lines, -36 lines 0 comments Download
M ash/common/wm/always_on_top_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/container_finder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/default_state.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/common/wm/dock/docked_window_layout_manager.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/common/wm/dock/docked_window_resizer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/fullscreen_window_finder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/panels/panel_layout_manager.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/common/wm/panels/panel_window_resizer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/wm/root_window_layout_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/wm/root_window_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/switchable_windows.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D ash/common/wm/wm_shell_window_ids.h View 1 1 chunk +0 lines, -64 lines 0 comments Download
M ash/common/wm/wm_window.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/workspace/multi_window_resize_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/workspace/phantom_window_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/workspace/workspace_window_resizer.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/container_delegate_aura.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/desktop_background/desktop_background_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/display/cursor_window_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_animator_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_position_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_position_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/display/shared_display_edge_indicator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/extended_desktop_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/first_run/desktop_cleaner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/first_run/first_run_helper_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/first_run/first_run_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/focus_cycler_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
D ash/root_window_controller_common.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ash/root_window_controller_common.cc View 1 chunk +0 lines, -221 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/overflow_bubble_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ash/shelf/shelf_widget.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/shell/lock_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/shell/window_type_launcher.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/shell/window_watcher.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
D ash/shell_window_ids.h View 1 1 chunk +0 lines, -197 lines 0 comments Download
M ash/sticky_keys/sticky_keys_overlay.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_widget.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/toast/toast_overlay.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_background_view.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/system/tray/tray_event_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/sysui/sysui_application.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/utility/screenshot_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/always_on_top_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_focus_rules.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_focus_rules_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/drag_window_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_client_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_layout_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/mru_window_tracker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/mru_window_tracker_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_grid.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_item.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/power_button_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/root_window_layout_manager.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ash/wm/root_window_layout_manager.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M ash/wm/root_window_layout_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/session_state_animator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/session_state_animator_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/session_state_animator_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/stacking_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/video_detector.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_animations_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/workspace_controller.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/chromevox_panel.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/overscan_calibrator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/mode_indicator_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/lock_window_aura.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/idle_app_name_notification_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/kiosk_external_update_notification.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/desktop_media_list_ash.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_keyboard_ui.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/network_connect_delegate_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_ash.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/exo/display.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/exo/display_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/exo/pointer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/exo/pointer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/exo/shell_surface.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/exo/shell_surface.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/exo/wayland/server.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/bridge/wm_globals_mus.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/bridge/wm_window_mus.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/container_ids.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/container_ids.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/root_window_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
sky
https://codereview.chromium.org/2025413002/diff/80001/ash/common/shell_window_ids.h File ash/common/shell_window_ids.h (right): https://codereview.chromium.org/2025413002/diff/80001/ash/common/shell_window_ids.h#newcode102 ash/common/shell_window_ids.h:102: // TODO(sky): remove. Temporary for rietveld to pick up ...
4 years, 6 months ago (2016-06-01 19:52:04 UTC) #2
James Cook
LGTM. Heh, you're writing code faster than I can review it / rebase onto it. ...
4 years, 6 months ago (2016-06-01 20:58:32 UTC) #3
sky
TBR reveman for more moves
4 years, 6 months ago (2016-06-01 21:26:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025413002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025413002/100001
4 years, 6 months ago (2016-06-01 21:28:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239361)
4 years, 6 months ago (2016-06-02 01:59:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025413002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025413002/100001
4 years, 6 months ago (2016-06-02 03:00:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239515)
4 years, 6 months ago (2016-06-02 03:44:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025413002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025413002/100001
4 years, 6 months ago (2016-06-02 13:06:48 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-02 13:46:39 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 13:48:32 UTC) #20
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/c096d9f102cb50ec1c5290ad5ef52636b4b4487e
Cr-Commit-Position: refs/heads/master@{#397384}

Powered by Google App Engine
This is Rietveld 408576698