Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2032363002: [gn] Add fuzzer targets. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Add fuzzer targets. This adds the v8-side fuzzer executables for smoke testing. This also renames the old gyp targets to stay consistent with chromium. Naming convention for type X after the rename: library: X_fuzzer (gn), X_fuzzer_lib (gyp) executable v8: v8_simple_X_fuzzer executable chromium: v8_X_fuzzer BUG=chromium:474921 Committed: https://crrev.com/63526069c2ba8cce249361e63ada57719d2b95ae Cr-Commit-Position: refs/heads/master@{#36713}

Patch Set 1 #

Patch Set 2 : Rename #

Total comments: 1

Patch Set 3 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -14 lines) Patch
M BUILD.gn View 1 2 8 chunks +36 lines, -0 lines 0 comments Download
M test/fuzzer/fuzzer.gyp View 1 6 chunks +10 lines, -8 lines 0 comments Download
M test/fuzzer/fuzzer.isolate View 1 1 chunk +5 lines, -5 lines 0 comments Download
M test/fuzzer/testcfg.py View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032363002/1
4 years, 6 months ago (2016-06-03 11:08:31 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/18786)
4 years, 6 months ago (2016-06-03 11:44:43 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032363002/20001
4 years, 6 months ago (2016-06-03 11:56:53 UTC) #6
Michael Achenbach
PTAL https://codereview.chromium.org/2032363002/diff/20001/test/fuzzer/fuzzer.gyp File test/fuzzer/fuzzer.gyp (right): https://codereview.chromium.org/2032363002/diff/20001/test/fuzzer/fuzzer.gyp#newcode175 test/fuzzer/fuzzer.gyp:175: 'v8_simple_wasm_fuzzer', Missing targets: bug
4 years, 6 months ago (2016-06-03 12:03:25 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 12:20:53 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032363002/40001
4 years, 6 months ago (2016-06-03 12:41:59 UTC) #13
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-03 12:51:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032363002/40001
4 years, 6 months ago (2016-06-03 13:06:08 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-03 13:09:57 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/63526069c2ba8cce249361e63ada57719d2b95ae Cr-Commit-Position: refs/heads/master@{#36713}
4 years, 6 months ago (2016-06-03 13:13:09 UTC) #21
vogelheim
4 years, 6 months ago (2016-06-03 14:09:02 UTC) #22
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698