Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Issue 2033813004: [gn] Add swarming support for all test targets (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@gn32
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Add swarming support for all test targets This adds corresponding *_run targets for all swarming isolate actions existing in gyp. This also wires all targets together under gn_all. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/976a62acd1515bd1006933fbc9ff9b723f940698 Cr-Commit-Position: refs/heads/master@{#36714}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -10 lines) Patch
M BUILD.gn View 1 2 chunks +4 lines, -4 lines 0 comments Download
M gni/isolate.gni View 2 chunks +15 lines, -6 lines 0 comments Download
A test/BUILD.gn View 1 2 3 4 5 1 chunk +210 lines, -0 lines 0 comments Download
A tools/BUILD.gn View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Michael Achenbach
PTAL. This ports all the *_run targets - roughly: https://cs.chromium.org/search/?q=test_isolation_mode+file:%5Esrc/v8/&sq=package:chromium&type=cs I kept things in BUILD.gn ...
4 years, 6 months ago (2016-06-03 13:30:18 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-03 13:31:35 UTC) #4
Michael Achenbach
Patch 6 fixes the fuzzer deps. Forgot to rewire after rebase...
4 years, 6 months ago (2016-06-03 13:33:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033813004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033813004/100001
4 years, 6 months ago (2016-06-03 13:44:12 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-03 13:46:15 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 13:48:53 UTC) #12
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/976a62acd1515bd1006933fbc9ff9b723f940698
Cr-Commit-Position: refs/heads/master@{#36714}

Powered by Google App Engine
This is Rietveld 408576698