Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2032263004: Add ability to rotate light direction in drawLitAtlas Sample slide (Closed)

Created:
4 years, 6 months ago by robertphillips
Modified:
4 years, 6 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org, egdaniel
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add ability to rotate light direction in drawLitAtlas Sample slide As requested by Greg. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2032263004 Committed: https://skia.googlesource.com/skia/+/862dae548a8ef40804bc9146d5c7b9f360efa960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -11 lines) Patch
M samplecode/SampleLitAtlas.cpp View 7 chunks +54 lines, -9 lines 0 comments Download
M src/core/SkLightingShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 6 months ago (2016-06-03 19:04:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032263004/1
4 years, 6 months ago (2016-06-03 19:05:23 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 19:22:34 UTC) #8
jvanverth1
lgtm
4 years, 6 months ago (2016-06-03 21:01:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032263004/1
4 years, 6 months ago (2016-06-03 22:47:23 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 22:48:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/862dae548a8ef40804bc9146d5c7b9f360efa960

Powered by Google App Engine
This is Rietveld 408576698