Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2032143004: [Mac][Material Design] Bring Omnibox stroke and MD colors up to spec. (Closed)

Created:
4 years, 6 months ago by shrike
Modified:
4 years, 6 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Bring Omnibox stroke and MD colors up to spec. This cl changes the Omnibox's stroke in Incognito mode to match the recent spec revisions made by sgabriel@. Changing to the new spec also required switching other MD colors to the sRGB color space so that everything matched. The plan was to switch to sRGB (which is correct - the calibrated space is not) eventually, but to get the Omnibox to look right, now is the time. R=avi@chromium.org,sky@chromium.org BUG=613749 Review-Url: https://codereview.chromium.org/2013183003 Cr-Commit-Position: refs/heads/master@{#396986} (cherry picked from commit 7a7f2e398b53990858d88bc19115c137630795f3) Committed: https://chromium.googlesource.com/chromium/src/+/793018247051e845ad6754e0344f5f892349237f

Patch Set 1 #

Messages

Total messages: 3 (1 generated)
shrike
Committed patchset #1 (id:1) manually as 793018247051e845ad6754e0344f5f892349237f.
4 years, 6 months ago (2016-06-03 18:31:47 UTC) #2
shrike
4 years, 6 months ago (2016-06-03 20:30:54 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2035153002/ by shrike@chromium.org.

The reason for reverting is: Broke the continuous build because of a missing
symbol. 

https://chromegw.corp.google.com/i/official.desktop.continuous/builders/mac%2...

FAILED:
obj/chrome/browser/ui/cocoa/location_bar/browser_ui.location_bar_view_mac.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/chrome/browser/ui/cocoa/location_bar/browser_ui.location_bar_view_mac.o.d
-DV8_DEPRECATION_WARNINGS -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0
-DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=269902-1 -DENABLE_RLZ
-DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1
-DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS
-DENABLE_TOPCHROME_MD=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_PROD_WALLET_SERVICE=1
-DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1
-DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
-DSAFE_BROWSING_DB_LOCAL -DMOJO_USE_SYSTEM_IMPL -DTOOLKIT_VIEWS=1
-DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_SUPPORT_GPU=1
-DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0
-DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DUSE_CUPS
'-DI18N_ADDRESS_VALIDATION_DATA_URL="https://i18napis.appspot.com/ssl-aggregate-address/"'
-DI18N_ADDRESSINPUT_USE_BASICTYPES_OVERRIDE=1 -DUSE_LIBPCI=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DOFFICIAL_BUILD
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../..
-Iobj/chrome/browser_ui.gen -Iobj/chrome/browser_ui.gen/chrome
-I../../skia/config -I../../third_party/khronos -I../../gpu -Igen/angle
-I../../third_party/WebKit/Source -Igen/chrome -Igen/protoc_out
-I../../third_party/protobuf/src
-I../../third_party/dom_distiller_js/dist/proto_gen -Igen/policy
-Igen/components -Igen/components/strings -I../../third_party/WebKit
-Igen/third_party/WebKit -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf
-I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../third_party/skia/include/utils/mac -I../../skia/ext
-I../../third_party/cacheinvalidation/overrides
-I../../third_party/cacheinvalidation/src
-I../../third_party/cacheinvalidation/google/cacheinvalidation
-I../../third_party/icu/source/i18n -I../../third_party/icu/source/common
-I../../third_party/zlib -Igen/ui/resources -Igen/content/app/resources/
-I../../third_party/libwebm/source -I../../third_party/opus/src/include
-I../../third_party/leveldatabase/src/include
-I../../third_party/leveldatabase/src -I../../third_party/leveldatabase
-I../../third_party/re2/src -I../../v8/include
-I../../third_party/google_toolbox_for_mac
-I../../third_party/google_toolbox_for_mac/src
-I../../third_party/google_toolbox_for_mac/src/AppKit
-I../../third_party/google_toolbox_for_mac/src/DebugUtils
-I../../third_party/google_toolbox_for_mac/src/Foundation
-Igen/ui/views/resources -I../../third_party/libaddressinput/chromium/override
-I../../third_party/libaddressinput/src/cpp/include
-Igen/third_party/libaddressinput/ -isysroot
/Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk
-O2 -gdwarf-2 -fvisibility=hidden -Werror -mmacosx-version-min=10.7 -arch x86_64
-Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers
-Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene
-Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonnull
-Wexit-time-destructors -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions
-fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang
/b/build/slave/mac_beta/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
-plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang
-plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors
-fcolor-diagnostics -fno-strict-aliasing -fno-standalone-debug
-Wobjc-missing-property-synthesis -fobjc-call-cxx-cdtors  -c
../../chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm -o
obj/chrome/browser/ui/cocoa/location_bar/browser_ui.location_bar_view_mac.o
../../chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:583:29:
error: no member named 'GetSecureTextColor' in 'OmniboxViewMac'
            OmniboxViewMac::GetSecureTextColor(security_level, in_dark_mode);
            ~~~~~~~~~~~~~~~~^
.

Powered by Google App Engine
This is Rietveld 408576698