[Mac][Material Design] Bring Omnibox stroke and MD colors up to spec.

[Mac][Material Design] Bring Omnibox stroke and MD colors up to spec.

This cl changes the Omnibox's stroke in Incognito mode to match the
recent spec revisions made by sgabriel@.

Changing to the new spec also required switching other MD colors to the
sRGB color space so that everything matched. The plan was to switch to
sRGB (which is correct - the calibrated space is not) eventually, but
to get the Omnibox to look right, now is the time.

R=avi@chromium.org,sky@chromium.org
BUG=613749
Committed: https://crrev.com/7a7f2e398b53990858d88bc19115c137630795f3
Cr-Commit-Position: refs/heads/master@{#396986}

[shrike, 2016-05-26 20:54:53]

Description was changed from

==========
[Mac][Material Design] Bring Omnibox stroke and MD colors up to spec.

This cl changes the Omnibox's stroke in Incognito mode to match the
recent spec revisions made by sgabriel@.

Changing to the new spec also required switching other MD colors to the
sRGB color space so that everything matched. The plan was to switch to
sRGB (which is correct - the calibrated space is not) eventually, but
to get the Omnibox to look right, now is the time.

R=avi@chromium.org
BUG=613749
==========

to

==========
[Mac][Material Design] Bring Omnibox stroke and MD colors up to spec.

This cl changes the Omnibox's stroke in Incognito mode to match the
recent spec revisions made by sgabriel@.

Changing to the new spec also required switching other MD colors to the
sRGB color space so that everything matched. The plan was to switch to
sRGB (which is correct - the calibrated space is not) eventually, but
to get the Omnibox to look right, now is the time.

R=avi@chromium.org,sky@chromium.org
BUG=613749
==========

[shrike, 2016-05-26 20:54:53]

shrike@chromium.org changed reviewers:
+ sky@chromium.org

[shrike, 2016-05-26 20:55:20]

PTAL

sky@
chrome/browser/themes/theme_service_mac.mm

avi@
everything else

[Avi (use Gerrit), 2016-05-26 21:00:22]

lgtm

[sky, 2016-05-26 22:32:57]

LGTM

https://codereview.chromium.org/2013183003/diff/1/chrome/browser/themes/theme...
File chrome/browser/themes/theme_service_mac.mm (right):

https://codereview.chromium.org/2013183003/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_service_mac.mm:186: const bool kIsModeMaterial =
ui::MaterialDesignController::IsModeMaterial();
mode_material as this isn't a compile time constant (like
kMaterialDesignIdOffset above).

[shrike, 2016-05-31 16:26:35]

https://codereview.chromium.org/2013183003/diff/1/chrome/browser/themes/theme...
File chrome/browser/themes/theme_service_mac.mm (right):

https://codereview.chromium.org/2013183003/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_service_mac.mm:186: const bool kIsModeMaterial =
ui::MaterialDesignController::IsModeMaterial();
On 2016/05/26 22:32:57, sky wrote:
> mode_material as this isn't a compile time constant (like
> kMaterialDesignIdOffset above).

Acknowledged.

[shrike, 2016-05-31 17:21:36]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-05-31 17:21:36]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2013183003/#ps20001
(title: "Address feedback.")

[commit-bot: I haz the power, 2016-05-31 17:22:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013183003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013183003/20001

[commit-bot: I haz the power, 2016-05-31 18:13:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 18:13:07]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[shrike, 2016-05-31 22:49:55]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-05-31 22:49:55]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2013183003/#ps60001
(title: "Fix compile error.")

[commit-bot: I haz the power, 2016-05-31 22:50:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013183003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013183003/60001

[commit-bot: I haz the power, 2016-06-01 00:05:40]

Description was changed from

==========
[Mac][Material Design] Bring Omnibox stroke and MD colors up to spec.

This cl changes the Omnibox's stroke in Incognito mode to match the
recent spec revisions made by sgabriel@.

Changing to the new spec also required switching other MD colors to the
sRGB color space so that everything matched. The plan was to switch to
sRGB (which is correct - the calibrated space is not) eventually, but
to get the Omnibox to look right, now is the time.

R=avi@chromium.org,sky@chromium.org
BUG=613749
==========

to

==========
[Mac][Material Design] Bring Omnibox stroke and MD colors up to spec.

This cl changes the Omnibox's stroke in Incognito mode to match the
recent spec revisions made by sgabriel@.

Changing to the new spec also required switching other MD colors to the
sRGB color space so that everything matched. The plan was to switch to
sRGB (which is correct - the calibrated space is not) eventually, but
to get the Omnibox to look right, now is the time.

R=avi@chromium.org,sky@chromium.org
BUG=613749
==========

[commit-bot: I haz the power, 2016-06-01 00:05:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-01 00:08:08]

Description was changed from

==========
[Mac][Material Design] Bring Omnibox stroke and MD colors up to spec.

This cl changes the Omnibox's stroke in Incognito mode to match the
recent spec revisions made by sgabriel@.

Changing to the new spec also required switching other MD colors to the
sRGB color space so that everything matched. The plan was to switch to
sRGB (which is correct - the calibrated space is not) eventually, but
to get the Omnibox to look right, now is the time.

R=avi@chromium.org,sky@chromium.org
BUG=613749
==========

to

==========
[Mac][Material Design] Bring Omnibox stroke and MD colors up to spec.

This cl changes the Omnibox's stroke in Incognito mode to match the
recent spec revisions made by sgabriel@.

Changing to the new spec also required switching other MD colors to the
sRGB color space so that everything matched. The plan was to switch to
sRGB (which is correct - the calibrated space is not) eventually, but
to get the Omnibox to look right, now is the time.

R=avi@chromium.org,sky@chromium.org
BUG=613749

Committed: https://crrev.com/7a7f2e398b53990858d88bc19115c137630795f3
Cr-Commit-Position: refs/heads/master@{#396986}
==========

[commit-bot: I haz the power, 2016-06-01 00:08:09]

Patchset 4 (id:??) landed as
https://crrev.com/7a7f2e398b53990858d88bc19115c137630795f3
Cr-Commit-Position: refs/heads/master@{#396986}