Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1813)

Unified Diff: content/shell/app/shell_crash_reporter_client.h

Issue 2031833002: Remove FilePath usage from the CrashReporterClient interface on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused constant to fix clang Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/content/app/crashpad_win.cc ('k') | content/shell/app/shell_crash_reporter_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/app/shell_crash_reporter_client.h
diff --git a/content/shell/app/shell_crash_reporter_client.h b/content/shell/app/shell_crash_reporter_client.h
index 1b2a58c449336428f53407b3259ed27333aa3337..1fe45c88a6d8f02a4e853bcadf090d04d0c5edd8 100644
--- a/content/shell/app/shell_crash_reporter_client.h
+++ b/content/shell/app/shell_crash_reporter_client.h
@@ -20,7 +20,7 @@ class ShellCrashReporterClient : public crash_reporter::CrashReporterClient {
#if defined(OS_WIN)
// Returns a textual description of the product type and version to include
// in the crash report.
- void GetProductNameAndVersion(const base::FilePath& exe_path,
+ void GetProductNameAndVersion(const base::string16& exe_path,
base::string16* product_name,
base::string16* version,
base::string16* special_build,
@@ -38,7 +38,11 @@ class ShellCrashReporterClient : public crash_reporter::CrashReporterClient {
// The location where minidump files should be written. Returns true if
// |crash_dir| was set.
+#if defined(OS_WIN)
+ bool GetCrashDumpLocation(base::string16* crash_dir) override;
+#else
bool GetCrashDumpLocation(base::FilePath* crash_dir) override;
+#endif
#if defined(OS_ANDROID)
// Returns the descriptor key of the android minidump global descriptor.
« no previous file with comments | « components/crash/content/app/crashpad_win.cc ('k') | content/shell/app/shell_crash_reporter_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698