Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: content/shell/app/shell_crash_reporter_client.h

Issue 2031833002: Remove FilePath usage from the CrashReporterClient interface on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused constant to fix clang Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_APP_SHELL_CRASH_REPORTER_CLIENT_H_ 5 #ifndef CONTENT_SHELL_APP_SHELL_CRASH_REPORTER_CLIENT_H_
6 #define CONTENT_SHELL_APP_SHELL_CRASH_REPORTER_CLIENT_H_ 6 #define CONTENT_SHELL_APP_SHELL_CRASH_REPORTER_CLIENT_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
11 #include "components/crash/content/app/crash_reporter_client.h" 11 #include "components/crash/content/app/crash_reporter_client.h"
12 12
13 namespace content { 13 namespace content {
14 14
15 class ShellCrashReporterClient : public crash_reporter::CrashReporterClient { 15 class ShellCrashReporterClient : public crash_reporter::CrashReporterClient {
16 public: 16 public:
17 ShellCrashReporterClient(); 17 ShellCrashReporterClient();
18 ~ShellCrashReporterClient() override; 18 ~ShellCrashReporterClient() override;
19 19
20 #if defined(OS_WIN) 20 #if defined(OS_WIN)
21 // Returns a textual description of the product type and version to include 21 // Returns a textual description of the product type and version to include
22 // in the crash report. 22 // in the crash report.
23 void GetProductNameAndVersion(const base::FilePath& exe_path, 23 void GetProductNameAndVersion(const base::string16& exe_path,
24 base::string16* product_name, 24 base::string16* product_name,
25 base::string16* version, 25 base::string16* version,
26 base::string16* special_build, 26 base::string16* special_build,
27 base::string16* channel_name) override; 27 base::string16* channel_name) override;
28 #endif 28 #endif
29 29
30 #if defined(OS_POSIX) && !defined(OS_MACOSX) 30 #if defined(OS_POSIX) && !defined(OS_MACOSX)
31 // Returns a textual description of the product type and version to include 31 // Returns a textual description of the product type and version to include
32 // in the crash report. 32 // in the crash report.
33 void GetProductNameAndVersion(const char** product_name, 33 void GetProductNameAndVersion(const char** product_name,
34 const char** version) override; 34 const char** version) override;
35 35
36 base::FilePath GetReporterLogFilename() override; 36 base::FilePath GetReporterLogFilename() override;
37 #endif 37 #endif
38 38
39 // The location where minidump files should be written. Returns true if 39 // The location where minidump files should be written. Returns true if
40 // |crash_dir| was set. 40 // |crash_dir| was set.
41 #if defined(OS_WIN)
42 bool GetCrashDumpLocation(base::string16* crash_dir) override;
43 #else
41 bool GetCrashDumpLocation(base::FilePath* crash_dir) override; 44 bool GetCrashDumpLocation(base::FilePath* crash_dir) override;
45 #endif
42 46
43 #if defined(OS_ANDROID) 47 #if defined(OS_ANDROID)
44 // Returns the descriptor key of the android minidump global descriptor. 48 // Returns the descriptor key of the android minidump global descriptor.
45 int GetAndroidMinidumpDescriptor() override; 49 int GetAndroidMinidumpDescriptor() override;
46 #endif 50 #endif
47 51
48 bool EnableBreakpadForProcess(const std::string& process_type) override; 52 bool EnableBreakpadForProcess(const std::string& process_type) override;
49 53
50 private: 54 private:
51 DISALLOW_COPY_AND_ASSIGN(ShellCrashReporterClient); 55 DISALLOW_COPY_AND_ASSIGN(ShellCrashReporterClient);
52 }; 56 };
53 57
54 } // namespace content 58 } // namespace content
55 59
56 #endif // CONTENT_SHELL_APP_SHELL_CRASH_REPORTER_CLIENT_H_ 60 #endif // CONTENT_SHELL_APP_SHELL_CRASH_REPORTER_CLIENT_H_
OLDNEW
« no previous file with comments | « components/crash/content/app/crashpad_win.cc ('k') | content/shell/app/shell_crash_reporter_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698