Mojo C++ bindings: more consistent Clone() and Equals().

Mojo C++ bindings: more consistent Clone() and Equals().

With this change, the Clone() and Equals() methods of structs/unions/maps/arrays call Clone() and Equals() of elements if available, otherwise fall back on copy and == operator of elements.

BUG=616527
Committed: https://crrev.com/14c4e1dca371579ceef264b8e3272b07c8bb92cb
Cr-Commit-Position: refs/heads/master@{#397717}

[yzshen1, 2016-06-01 21:49:41]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org, sammc@chromium.org

[yzshen1, 2016-06-01 21:49:42]

Hi, Ken and Sam.

Would you please take a look? Thanks!

[yzshen1, 2016-06-01 22:58:03]

On 2016/06/01 21:49:42, yzshen1 wrote:
> Hi, Ken and Sam.
> 
> Would you please take a look? Thanks!

Hmm.... Non-windows builds are not happy because the new mojo::internal::Clone()
function template that I introduced sometimes is used with incomplete type
mojo::InlinedStructPtr<Foo>. Unlike mojo::StructPtr<Foo>, Foo cannot be a
forward-declared type.

I will need to look into how to fix it. If you haven't reviewed the change,
please hold off. Ideas about how to overcome this issue are welcomed!

[yzshen1, 2016-06-01 23:46:10]

On 2016/06/01 22:58:03, yzshen1 wrote:
> On 2016/06/01 21:49:42, yzshen1 wrote:
> > Hi, Ken and Sam.
> > 
> > Would you please take a look? Thanks!
> 
> Hmm.... Non-windows builds are not happy because the new
mojo::internal::Clone()
> function template that I introduced sometimes is used with incomplete type
> mojo::InlinedStructPtr<Foo>. Unlike mojo::StructPtr<Foo>, Foo cannot be a
> forward-declared type.
> 
> I will need to look into how to fix it. If you haven't reviewed the change,
> please hold off. Ideas about how to overcome this issue are welcomed!

New patch is uploaded. It should make the bots happy now. PTAL

[Ken Rockot(use gerrit already), 2016-06-02 20:18:05]

lgtm

[yzshen1, 2016-06-03 15:58:16]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-06-03 15:58:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031823002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2031823002/60001

[commit-bot: I haz the power, 2016-06-03 16:04:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-03 16:05:14]

Description was changed from

==========
Mojo C++ bindings: more consistent Clone() and Equals().

With this change, the Clone() and Equals() methods of structs/unions/maps/arrays
call Clone() and Equals() of elements if available, otherwise fall back on copy
and == operator of elements.

BUG=616527
==========

to

==========
Mojo C++ bindings: more consistent Clone() and Equals().

With this change, the Clone() and Equals() methods of structs/unions/maps/arrays
call Clone() and Equals() of elements if available, otherwise fall back on copy
and == operator of elements.

BUG=616527

Committed: https://crrev.com/14c4e1dca371579ceef264b8e3272b07c8bb92cb
Cr-Commit-Position: refs/heads/master@{#397717}
==========

[commit-bot: I haz the power, 2016-06-03 16:05:16]

Patchset 4 (id:??) landed as
https://crrev.com/14c4e1dca371579ceef264b8e3272b07c8bb92cb
Cr-Commit-Position: refs/heads/master@{#397717}