mojo/public/tools/bindings/generators/mojom_cpp_generator.py - Issue 2031823002: Mojo C++ bindings: more consistent Clone() and Equals().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Issue 2031823002: Mojo C++ bindings: more consistent Clone() and Equals(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_template_definition.tmpl ('k') | mojo/public/tools/bindings/pylib/mojom/generate/module.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

index d8e0491cc309d0f8475e7eab1b2139925e9b03b6..8f9c4d5365547cb027c6b1c338f34f8683e70e27 100644

--- a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

@@ -135,9 +135,6 @@ def IsTypemappedKind(kind):

return hasattr(kind, "name") and \

GetFullMojomNameForKind(kind) in _current_typemap

-def IsCloneableKind(kind):

- return mojom.IsCloneableKind(kind, IsTypemappedKind)

def IsNativeOnlyKind(kind):

return mojom.IsStructKind(kind) and kind.native_only

@@ -444,7 +441,6 @@ class Generator(generator.Generator):

"should_inline": ShouldInlineStruct,

"should_inline_union": ShouldInlineUnion,

"is_array_kind": mojom.IsArrayKind,

- "is_cloneable_kind": IsCloneableKind,

"is_enum_kind": mojom.IsEnumKind,

"is_integral_kind": mojom.IsIntegralKind,

"is_move_only_kind": mojom.IsMoveOnlyKind,