Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 203173003: Array constructor expects AllocationSite or undefined as feedback. (Closed)

Created:
6 years, 9 months ago by mvstanton
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Array constructor expects AllocationSite or undefined as feedback. Redefine Array constructor to expect an AllocationSite in the feedback register or undefined. This will make code simpler as we support pretenuring feedback for all constructed objects. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20064

Patch Set 1 #

Patch Set 2 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -156 lines) Patch
M src/a64/builtins-a64.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M src/a64/code-stubs-a64.cc View 1 4 chunks +21 lines, -33 lines 0 comments Download
M src/a64/lithium-codegen-a64.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 4 chunks +19 lines, -28 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 4 chunks +22 lines, -27 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 4 chunks +18 lines, -26 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Hannes, as discussed, here is a snippet of work from the already-reviewed pretenure-call-new support ...
6 years, 9 months ago (2014-03-18 12:34:36 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 9 months ago (2014-03-19 11:37:41 UTC) #2
mvstanton
6 years, 9 months ago (2014-03-19 11:51:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20064 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698