src/runtime.cc - Issue 203173003: Array constructor expects AllocationSite or undefined as feedback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 203173003: Array constructor expects AllocationSite or undefined as feedback. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Ports. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 75b9f2ffdba65109984bf3cf05c040fc5e3e560e..04f9a1926b8c3850e4028d8dabca3ee3aa69f3d0 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -14853,8 +14853,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_ArrayConstructor) {

Handle<AllocationSite> site;

if (!type_info.is_null() &&

- !type_info.is_identical_to(

- TypeFeedbackInfo::MegamorphicSentinel(isolate))) {

+ *type_info != isolate->heap()->undefined_value()) {

site = Handle<AllocationSite>::cast(type_info);

ASSERT(!site->SitePointsToLiteral());

}

« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »