Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2031653003: Get rid of NULLs in fpdfsdk/ (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@nullptr_core
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 : Git rid of comparisons against NULL #

Patch Set 2 : s/NULL/nullptr/ #

Patch Set 3 : Fix build, undo change in fpdfsdk/fpdfview_c_api_test.c #

Patch Set 4 : Missed some NULLs #

Patch Set 5 : Fix bad search/replace #

Total comments: 15

Patch Set 6 : rebase #

Patch Set 7 : Address comments #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -371 lines) Patch
M core/fxcodec/codec/fx_codec_jpx_unittest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_basic_bstring_unittest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/include/fx_memory.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/formfiller/cba_fontmap.cpp View 1 2 3 8 chunks +15 lines, -15 lines 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 1 4 chunks +12 lines, -9 lines 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.cpp View 1 3 chunks +2 lines, -5 lines 0 comments Download
M fpdfsdk/fpdf_dataavail.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdf_ext.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 1 2 3 4 5 5 chunks +7 lines, -5 lines 0 comments Download
M fpdfsdk/fpdf_sysfontinfo.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfdoc.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfeditimg.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfeditpage.cpp View 1 2 3 4 5 6 4 chunks +4 lines, -5 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 2 3 4 5 6 5 chunks +6 lines, -7 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 3 4 5 6 11 chunks +13 lines, -18 lines 0 comments Download
M fpdfsdk/fpdfview_embeddertest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 1 2 3 4 5 5 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 1 14 chunks +23 lines, -33 lines 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fsdk_actionhandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_annothandler.cpp View 1 9 chunks +15 lines, -15 lines 0 comments Download
M fpdfsdk/fsdk_baseannot.cpp View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 1 2 3 4 5 6 8 chunks +11 lines, -13 lines 0 comments Download
M fpdfsdk/fsdk_mgr.cpp View 1 2 3 9 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/fsdk_rendercontext.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/fxedit/fxet_ap.cpp View 1 2 3 4 5 6 1 chunk +5 lines, -6 lines 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 1 2 3 4 chunks +17 lines, -17 lines 0 comments Download
M fpdfsdk/fxedit/fxet_list.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fxedit/fxet_pageobjs.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/fxedit/include/fx_edit.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/fxedit/include/fxet_edit.h View 1 4 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/fxedit/include/fxet_list.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 5 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/Field.cpp View 1 2 3 4 5 6 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/javascript/Icon.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_EventHandler.cpp View 1 2 chunks +18 lines, -18 lines 0 comments Download
M fpdfsdk/javascript/JS_GlobalData.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_Object.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/JS_Value.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/global.cpp View 1 2 3 4 5 chunks +16 lines, -14 lines 0 comments Download
M fpdfsdk/jsapi/fxjs_v8.cpp View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Caret.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_ComboBox.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 1 9 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Icon.cpp View 1 3 chunks +5 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_IconList.cpp View 1 2 3 5 chunks +8 lines, -5 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Label.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListBox.cpp View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ScrollBar.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Signature.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Utils.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Utils.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Wnd.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Wnd.cpp View 1 9 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Lei Zhang
Tired of changing NULLs a few at a time.
4 years, 6 months ago (2016-06-02 04:38:51 UTC) #2
Tom Sepez
https://codereview.chromium.org/2031653003/diff/80001/fpdfsdk/fpdfdoc_embeddertest.cpp File fpdfsdk/fpdfdoc_embeddertest.cpp (right): https://codereview.chromium.org/2031653003/diff/80001/fpdfsdk/fpdfdoc_embeddertest.cpp#newcode21 fpdfsdk/fpdfdoc_embeddertest.cpp:21: // nullptr FPDF_DEST case. NULL preferred in comment, I ...
4 years, 6 months ago (2016-06-02 20:26:26 UTC) #3
Lei Zhang
https://codereview.chromium.org/2031653003/diff/80001/fpdfsdk/fpdfdoc_embeddertest.cpp File fpdfsdk/fpdfdoc_embeddertest.cpp (right): https://codereview.chromium.org/2031653003/diff/80001/fpdfsdk/fpdfdoc_embeddertest.cpp#newcode21 fpdfsdk/fpdfdoc_embeddertest.cpp:21: // nullptr FPDF_DEST case. On 2016/06/02 20:26:26, Tom Sepez ...
4 years, 6 months ago (2016-06-07 08:03:14 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/2031653003/diff/80001/fpdfsdk/fsdk_baseform.cpp File fpdfsdk/fsdk_baseform.cpp (right): https://codereview.chromium.org/2031653003/diff/80001/fpdfsdk/fsdk_baseform.cpp#newcode2491 fpdfsdk/fsdk_baseform.cpp:2491: FX_Free(pBuffer); On 2016/06/07 08:03:13, Lei Zhang (Slow) wrote: ...
4 years, 6 months ago (2016-06-07 16:08:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031653003/140001
4 years, 6 months ago (2016-06-08 00:33:20 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 00:53:16 UTC) #10
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://pdfium.googlesource.com/pdfium/+/1cd352e0a4bc19f96df199b0acfa32a34424...

Powered by Google App Engine
This is Rietveld 408576698