core/fxcrt/fx_basic_bstring_unittest.cpp - Issue 2031653003: Get rid of NULLs in fpdfsdk/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_basic_bstring_unittest.cpp

Issue 2031653003: Get rid of NULLs in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@nullptr_core

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/fx_basic_bstring_unittest.cpp

diff --git a/core/fxcrt/fx_basic_bstring_unittest.cpp b/core/fxcrt/fx_basic_bstring_unittest.cpp

index 220105aa9548186be58fd17b5e5b3ae1e61258d7..cfdf2794b42ea2fcf72ebca2a665a6669f2664c4 100644

--- a/core/fxcrt/fx_basic_bstring_unittest.cpp

+++ b/core/fxcrt/fx_basic_bstring_unittest.cpp

@@ -758,7 +758,7 @@ TEST(fxcrt, ByteStringCFromChar) {

CFX_ByteStringC nul_string_from_char(nul);

CFX_ByteStringC lower_a_string_from_char(lower_a);

- // Pointer to nul, not NULL ptr, hence length 1 ...

+ // Pointer to nul, not nullptr ptr, hence length 1 ...

EXPECT_EQ(1, nul_string_from_char.GetLength());

EXPECT_NE(null_string, nul_string_from_char);

« no previous file with comments | « core/fxcodec/codec/fx_codec_jpx_unittest.cpp ('k') | core/fxcrt/include/fx_memory.h » ('j') | no next file with comments »