Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

Issue 2031393003: WebAudio: record whether user gesture was available and provided. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
index c1ff657683969e77b6d366583016fa35740e166f..f0d121d5d317cf6e3840181cfddde18e9c43bbe1 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
@@ -441,6 +441,8 @@ void AudioBufferSourceHandler::startSource(double when, double grainOffset, doub
{
ASSERT(isMainThread());
+ context()->recordUserGesture();
Raymond Toy 2016/06/03 17:57:52 Not sure if this is the right place. Say you've c
mlamouri (slow - plz ping) 2016/06/05 14:44:57 As above, I'm following WebKit's behaviour here. T
Raymond Toy 2016/06/06 15:10:07 Acknowledged.
+
if (playbackState() != UNSCHEDULED_STATE) {
exceptionState.throwDOMException(
InvalidStateError,

Powered by Google App Engine
This is Rietveld 408576698