third_party/WebKit/Source/modules/webaudio/AudioContext.cpp - Issue 2031393003: WebAudio: record whether user gesture was available and provided.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioContext.cpp

Issue 2031393003: WebAudio: record whether user gesture was available and provided. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioContext.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp b/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp

index e45fbf22d878e21d2aca2e1e491cee4fa2fc6e2d..c0975b240ad67da4122fa7fe1fd393ae59426ffa 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp

@@ -116,6 +116,8 @@ ScriptPromise AudioContext::resumeContext(ScriptState* scriptState)

{

ASSERT(isMainThread());

+ recordUserGesture();

Raymond Toy 2016/06/03 17:57:52 I think you probably want to do this around line 1

mlamouri (slow - plz ping) 2016/06/05 14:44:57 Done.

if (isContextClosed()) {

return ScriptPromise::rejectWithDOMException(

scriptState,

@@ -198,4 +200,3 @@ void AudioContext::stopRendering()

}

} // namespace blink