Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2031353002: SVGFE{Spot,Distant,Point}LightElement can have non-SVGFE*Lighting parent (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SVGFE{Spot,Distant,Point}LightElement can have non-SVGFE*Lighting parent Replace ASSERT_NOT_REACHED with a return statement. We already thoroughly check for valid parent type and only notify them if so. BUG=518649 Committed: https://crrev.com/1aef424b12048b58ceb286f645629a8e6e90b515 Cr-Commit-Position: refs/heads/master@{#397941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/svg/filters/feLight-non-lighting-parent-crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/filters/feLight-non-lighting-parent-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFELightElement.cpp View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
Another whack-an-olde-non-complexus.
4 years, 6 months ago (2016-06-04 14:00:30 UTC) #2
pdr.
lgtm
4 years, 6 months ago (2016-06-04 23:40:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031353002/1
4 years, 6 months ago (2016-06-04 23:40:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-05 20:04:44 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-05 20:07:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1aef424b12048b58ceb286f645629a8e6e90b515
Cr-Commit-Position: refs/heads/master@{#397941}

Powered by Google App Engine
This is Rietveld 408576698