Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: third_party/WebKit/Source/core/svg/SVGFELightElement.cpp

Issue 2031353002: SVGFE{Spot,Distant,Point}LightElement can have non-SVGFE*Lighting parent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/filters/feLight-non-lighting-parent-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGFELightElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGFELightElement.cpp b/third_party/WebKit/Source/core/svg/SVGFELightElement.cpp
index 6a1de14d42e99f5a1a5deb3f87bac2d3972228d5..26333350f0472d0717c077653e49785af727ab27 100644
--- a/third_party/WebKit/Source/core/svg/SVGFELightElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGFELightElement.cpp
@@ -105,16 +105,12 @@ void SVGFELightElement::svgAttributeChanged(const QualifiedName& attrName)
return;
SVGElement::InvalidationGuard invalidationGuard(this);
- if (isSVGFEDiffuseLightingElement(*parent)) {
+ if (isSVGFEDiffuseLightingElement(*parent))
toSVGFEDiffuseLightingElement(*parent).lightElementAttributeChanged(this, attrName);
- return;
- }
- if (isSVGFESpecularLightingElement(*parent)) {
+ else if (isSVGFESpecularLightingElement(*parent))
toSVGFESpecularLightingElement(*parent).lightElementAttributeChanged(this, attrName);
- return;
- }
- ASSERT_NOT_REACHED();
+ return;
}
SVGElement::svgAttributeChanged(attrName);
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/filters/feLight-non-lighting-parent-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698