Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/toolchain/mac/BUILD.gn

Issue 2031233002: Rework how MB and GN handle concurrent links. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/gcc_toolchain.gni ('k') | build/toolchain/toolchain.gni » ('j') | build/toolchain/toolchain.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/mac/BUILD.gn
diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn
index e3d65c72bdeca4041e99146a826853a6b66606f9..97739cec71e51007489e874f10e450bd27a13d16 100644
--- a/build/toolchain/mac/BUILD.gn
+++ b/build/toolchain/mac/BUILD.gn
@@ -39,6 +39,8 @@ template("mac_toolchain") {
assert(defined(invoker.toolchain_os),
"mac_toolchain() must specify a \"toolchain_os\"")
+ # concurrent_links is picked up from the declare_arg().
+
# We can't do string interpolation ($ in strings) on things with dots in
# them. To allow us to use $cc below, for example, we create copies of
# these values in our scope.
« no previous file with comments | « build/toolchain/gcc_toolchain.gni ('k') | build/toolchain/toolchain.gni » ('j') | build/toolchain/toolchain.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698