Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2230)

Unified Diff: build/toolchain/gcc_toolchain.gni

Issue 2031233002: Rework how MB and GN handle concurrent links. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/toolchain/gcc_toolchain.gni
diff --git a/build/toolchain/gcc_toolchain.gni b/build/toolchain/gcc_toolchain.gni
index 06546f3da6624c0e998d657b09760dfb605085be..c625f77cb109347bfd80338f2bf577092e925351 100644
--- a/build/toolchain/gcc_toolchain.gni
+++ b/build/toolchain/gcc_toolchain.gni
@@ -8,16 +8,6 @@ import("//build/toolchain/cc_wrapper.gni")
import("//build/toolchain/goma.gni")
import("//build/toolchain/toolchain.gni")
-# "concurrent_links" is a toolchain variable. By computing it here rather than
-# inside the toolchain, the exec_script will only get run once rather than
-# each time the toolchain template is invoked.
-if (allow_posix_link_time_opt || is_cfi) {
- concurrent_links_ =
- exec_script("get_concurrent_links.py", [ "--lto" ], "value")
-} else {
- concurrent_links_ = exec_script("get_concurrent_links.py", [], "value")
-}
-
# This template defines a toolchain for something that works like gcc
# (including clang).
#
@@ -118,8 +108,6 @@ template("gcc_toolchain") {
assert(defined(invoker.toolchain_os),
"gcc_toolchain() must specify a \"toolchain_os\"")
- concurrent_links = concurrent_links_
-
if (defined(invoker.cc_wrapper)) {
cc_wrapper = invoker.cc_wrapper
}
« no previous file with comments | « .gn ('k') | build/toolchain/mac/BUILD.gn » ('j') | build/toolchain/toolchain.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698