Issue 2031153002: Fix sed expression to substitute recalculated fingerprints after format change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2031153002: Fix sed expression to substitute recalculated fingerprints after format change. (Closed)

Created:
4 years, 6 months ago by regis

Modified:
4 years, 6 months ago

Reviewers:
Florian Schneider, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+418 lines, -423 lines)			Patch
	M	runtime/vm/method_recognizer.h	View	1	4 chunks	+416 lines, -420 lines	0 comments	Download
	M	runtime/vm/object.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

regis

This simplified expression may not work in case of a fp collision, but, in practice, ...

4 years, 6 months ago (2016-06-02 22:46:38 UTC) #2

regis

4 years, 6 months ago (2016-06-03 21:38:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4524d15d529fc8b1e2a64558ee6894f0ac6f3770 (presubmit successful).