Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: runtime/vm/object.cc

Issue 2031153002: Fix sed expression to substitute recalculated fingerprints after format change. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: format fingerprints to fixed size hex for easier substitution Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/method_recognizer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/become.h" 10 #include "vm/become.h"
(...skipping 7121 matching lines...) Expand 10 before | Expand all | Expand 10 after
7132 } 7132 }
7133 7133
7134 7134
7135 bool Function::CheckSourceFingerprint(const char* prefix, int32_t fp) const { 7135 bool Function::CheckSourceFingerprint(const char* prefix, int32_t fp) const {
7136 if (SourceFingerprint() != fp) { 7136 if (SourceFingerprint() != fp) {
7137 const bool recalculatingFingerprints = false; 7137 const bool recalculatingFingerprints = false;
7138 if (recalculatingFingerprints) { 7138 if (recalculatingFingerprints) {
7139 // This output can be copied into a file, then used with sed 7139 // This output can be copied into a file, then used with sed
7140 // to replace the old values. 7140 // to replace the old values.
7141 // sed -i .bak -f /tmp/newkeys runtime/vm/method_recognizer.h 7141 // sed -i .bak -f /tmp/newkeys runtime/vm/method_recognizer.h
7142 THR_Print("s/V(%s, %d)/V(%s, %d)/\n", 7142 THR_Print("s/0x%08x/0x%08x/\n", fp, SourceFingerprint());
7143 prefix, fp, prefix, SourceFingerprint());
7144 } else { 7143 } else {
7145 THR_Print("FP mismatch while recognizing method %s:" 7144 THR_Print("FP mismatch while recognizing method %s:"
7146 " expecting %d found %d\n", 7145 " expecting 0x%08x found 0x%08x\n",
7147 ToFullyQualifiedCString(), 7146 ToFullyQualifiedCString(),
7148 fp, 7147 fp,
7149 SourceFingerprint()); 7148 SourceFingerprint());
7150 return false; 7149 return false;
7151 } 7150 }
7152 } 7151 }
7153 return true; 7152 return true;
7154 } 7153 }
7155 7154
7156 7155
(...skipping 15476 matching lines...) Expand 10 before | Expand all | Expand 10 after
22633 return UserTag::null(); 22632 return UserTag::null();
22634 } 22633 }
22635 22634
22636 22635
22637 const char* UserTag::ToCString() const { 22636 const char* UserTag::ToCString() const {
22638 const String& tag_label = String::Handle(label()); 22637 const String& tag_label = String::Handle(label());
22639 return tag_label.ToCString(); 22638 return tag_label.ToCString();
22640 } 22639 }
22641 22640
22642 } // namespace dart 22641 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/method_recognizer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698