IndexedDB Observers

third_party/WebKit/Source/modules/indexeddb/IDBValue.h

Index: third_party/WebKit/Source/modules/indexeddb/IDBValue.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBValue.h b/third_party/WebKit/Source/modules/indexeddb/IDBValue.h
index 69fd9c6abe53d0c607d4c82611b39f72c79bf76c..dce27f4715bcb352acacc6b4b83738774bc4247b 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBValue.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBValue.h
@@ -24,6 +24,7 @@ public:
     static PassRefPtr<IDBValue> create();
     static PassRefPtr<IDBValue> create(const WebIDBValue&);
     static PassRefPtr<IDBValue> create(const IDBValue*, IDBKey*, const IDBKeyPath&);
+    virtual ~IDBValue();

[Marijn Kruisselbrink, 2016/06/15 13:02:45]

Why this change?

[dmurph, 2016/06/15 13:10:48]

It was causing problems where BlobDataHandle and IDBKey needed to be included in
header files because the destructor here needs the destructor defined if we
don't virtualize it. So in our observer class it was complaining because
BlobDataHandle wasn't included for that compilation unit, even though we never
use blob data handles. 

[Marijn Kruisselbrink, 2016/06/15 13:22:37]

Sorry, I can't quite parse that sentence... What was complaining about what in
which situation?

[palakj1, 2016/06/15 19:16:31]

Our destructor calls the IDBValue destructor. Since, IDBValue destructor isn't
virtualized, it looked for BlobDataHandle (IDBValue holds a pointer to
BlobDataHandle) which isn't included in our compilation unit. This throws an
'access into incomplete type' error.

[Marijn Kruisselbrink, 2016/06/16 07:09:30]

That explains why you need an explicit destructor, with an implementation in the
.cpp file. It does not explain why suddenly that destructor needs to be virtual?

 
     bool isNull() const;
     Vector<String> getUUIDs() const;