IndexedDB Observers

third_party/WebKit/Source/modules/indexeddb/IDBValue.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IDBValue_h
 #define IDBValue_h
 
 #include "modules/ModulesExport.h"
 #include "modules/indexeddb/IDBKey.h"
 #include "modules/indexeddb/IDBKeyPath.h"
 #include "platform/SharedBuffer.h"
 #include "public/platform/WebVector.h"
 #include "wtf/OwnPtr.h"
 #include "wtf/RefPtr.h"
 
 namespace blink {
 
 class BlobDataHandle;
 class WebBlobInfo;
 struct WebIDBValue;
 
 class MODULES_EXPORT IDBValue final : public RefCounted<IDBValue> {
 public:
     static PassRefPtr<IDBValue> create();
     static PassRefPtr<IDBValue> create(const WebIDBValue&);
     static PassRefPtr<IDBValue> create(const IDBValue*, IDBKey*, const IDBKeyPath&);
+    virtual ~IDBValue();

[Marijn Kruisselbrink, 2016/06/15 13:02:45]

Why this change?

[dmurph, 2016/06/15 13:10:48]

It was causing problems where BlobDataHandle and IDBKey needed to be included in
header files because the destructor here needs the destructor defined if we
don't virtualize it. So in our observer class it was complaining because
BlobDataHandle wasn't included for that compilation unit, even though we never
use blob data handles. 

[Marijn Kruisselbrink, 2016/06/15 13:22:37]

Sorry, I can't quite parse that sentence... What was complaining about what in
which situation?

[palakj1, 2016/06/15 19:16:31]

Our destructor calls the IDBValue destructor. Since, IDBValue destructor isn't
virtualized, it looked for BlobDataHandle (IDBValue holds a pointer to
BlobDataHandle) which isn't included in our compilation unit. This throws an
'access into incomplete type' error.

[Marijn Kruisselbrink, 2016/06/16 07:09:30]

That explains why you need an explicit destructor, with an implementation in the
.cpp file. It does not explain why suddenly that destructor needs to be virtual?

 
     bool isNull() const;
     Vector<String> getUUIDs() const;
     const SharedBuffer* data() const;
     Vector<WebBlobInfo>* blobInfo() const { return m_blobInfo.get(); }
     const IDBKey* primaryKey() const { return m_primaryKey; }
     const IDBKeyPath& keyPath() const { return m_keyPath; }
 
 private:
     IDBValue();
     IDBValue(const WebIDBValue&);
     IDBValue(PassRefPtr<SharedBuffer>, const WebVector<WebBlobInfo>&, IDBKey*, const IDBKeyPath&);
     IDBValue(const IDBValue*, IDBKey*, const IDBKeyPath&);
 
     const RefPtr<SharedBuffer> m_data;
     const OwnPtr<Vector<RefPtr<BlobDataHandle>>> m_blobData;
     const OwnPtr<Vector<WebBlobInfo>> m_blobInfo;
     const Persistent<IDBKey> m_primaryKey;
     const IDBKeyPath m_keyPath;
 };
 
 } // namespace blink
 
 #endif