Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

Issue 2030933002: Make CronetHttpURLConnection#setConnectTimeout silently fail (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use Log.e Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
index 0fd87866e2cbf5e4f5bf51eb21b5fdbb2489eca4..708797f0e37a5164680e9d957afccd4ce520ec8d 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
@@ -96,12 +96,12 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {
public void testConnectTimeout() throws Exception {
URL url = new URL(NativeTestServer.getEchoMethodURL());
HttpURLConnection connection = (HttpURLConnection) url.openConnection();
- try {
- connection.setConnectTimeout(1000);
- fail();
- } catch (UnsupportedOperationException e) {
- // Expected
- }
+ // This should not throw an exception.
+ connection.setConnectTimeout(1000);
+ assertEquals(200, connection.getResponseCode());
+ assertEquals("OK", connection.getResponseMessage());
+ assertEquals("GET", TestUtil.getResponseAsString(connection));
+ connection.disconnect();
}
@SmallTest
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698