components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java - Issue 2030933002: Make CronetHttpURLConnection#setConnectTimeout silently fail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

Issue 2030933002: Make CronetHttpURLConnection#setConnectTimeout silently fail (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use Log.e Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

diff --git a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

index e03ce2ae45ef4fa4d4573979ce0e6d4357a3dbff..d420512f197629930ca7757076209938b3b743eb 100644

--- a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

+++ b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

@@ -34,7 +34,7 @@ import java.util.TreeMap;

* {@hide}

public class CronetHttpURLConnection extends HttpURLConnection {

- private static final String TAG = "cr.CronetHttpURLConn";

+ private static final String TAG = "cr_CronetHttpURLConn";

private static final String CONTENT_LENGTH = "Content-Length";

private final CronetEngine mCronetEngine;

private final MessageLoop mMessageLoop;

@@ -402,7 +402,7 @@ public class CronetHttpURLConnection extends HttpURLConnection {

// Sockets are assigned to requests according to request priorities

// when sockets are connected. This requires requests with the same host,

// domain and port to have same timeout.

- throw new UnsupportedOperationException("Not supported");

+ Log.e(TAG, "setConnectTimeout is not supported by CronetHttpURLConnection");

}

/**