Chromium Code Reviews| Index: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java |
| diff --git a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java |
| index e03ce2ae45ef4fa4d4573979ce0e6d4357a3dbff..2868a94ec30cbb27059f72e58241436429e48de4 100644 |
| --- a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java |
| +++ b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java |
| @@ -34,7 +34,7 @@ import java.util.TreeMap; |
| * {@hide} |
| */ |
| public class CronetHttpURLConnection extends HttpURLConnection { |
| - private static final String TAG = "cr.CronetHttpURLConn"; |
| + private static final String TAG = "cr_CronetHttpURLConn"; |
|
xunjieli
2016/06/02 13:27:36
The linter says do not use dot in the log tag.
src
|
| private static final String CONTENT_LENGTH = "Content-Length"; |
| private final CronetEngine mCronetEngine; |
| private final MessageLoop mMessageLoop; |
| @@ -402,7 +402,7 @@ public class CronetHttpURLConnection extends HttpURLConnection { |
| // Sockets are assigned to requests according to request priorities |
| // when sockets are connected. This requires requests with the same host, |
| // domain and port to have same timeout. |
| - throw new UnsupportedOperationException("Not supported"); |
| + Log.d(TAG, "setConnectTimeout is not supported by CronetHttpURLConnection"); |
|
pauljensen
2016/06/02 14:12:56
It might be worth upgrading this to Log.e()
xunjieli
2016/06/02 14:24:17
I considered using Log.e() but I decided to use th
pauljensen
2016/06/02 14:56:54
I think log spamming is an equal punishment to cal
xunjieli
2016/06/02 16:20:09
Done.
|
| } |
| /** |