Make CronetHttpURLConnection#setConnectTimeout silently fail

components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net.urlconnection;
 
 import android.util.Pair;
 
 import org.chromium.base.Log;
 import org.chromium.net.CronetEngine;
@@ skipping 16 matching lines @@
 import java.util.List;
 import java.util.Map;
 import java.util.TreeMap;
 
 /**
  * An implementation of {@link HttpURLConnection} that uses Cronet to send
  * requests and receive responses.
  * {@hide}
  */
 public class CronetHttpURLConnection extends HttpURLConnection {
-    private static final String TAG = "cr.CronetHttpURLConn";
+    private static final String TAG = "cr_CronetHttpURLConn";

[xunjieli, 2016/06/02 13:27:36]

The linter says do not use dot in the log tag.
src/docs/android_logging.md

     private static final String CONTENT_LENGTH = "Content-Length";
     private final CronetEngine mCronetEngine;
     private final MessageLoop mMessageLoop;
     private UrlRequest mRequest;
     private final List<Pair<String, String>> mRequestHeaders;
 
     private CronetInputStream mInputStream;
     private CronetOutputStream mOutputStream;
     private UrlResponseInfo mResponseInfo;
     private UrlRequestException mException;
@@ skipping 347 matching lines @@
         // TODO(xunjieli): implement this.
         return false;
     }
 
     @Override
     public void setConnectTimeout(int timeout) {
         // Per-request connect timeout is not supported because of late binding.
         // Sockets are assigned to requests according to request priorities
         // when sockets are connected. This requires requests with the same host,
         // domain and port to have same timeout.
-        throw new UnsupportedOperationException("Not supported");
+        Log.d(TAG, "setConnectTimeout is not supported by CronetHttpURLConnection");

[pauljensen, 2016/06/02 14:12:56]

It might be worth upgrading this to Log.e()

[xunjieli, 2016/06/02 14:24:17]

I considered using Log.e() but I decided to use the debug version as Log.e()s
aren't stripped in release builds. We might get too many of these logs since
there might be one per request. I don't feel strongly though. 

[pauljensen, 2016/06/02 14:56:54]

I think log spamming is an equal punishment to calling this function and not
understanding that it's not doing anything.  If an embedder is going to ship a
product that calls this function, we don't want to break their app but at the
same time we'd rather they understand this function isn't doing anything.

[xunjieli, 2016/06/02 16:20:09]

Done.

     }
 
     /**
      * Used by {@link CronetInputStream} to get more data from the network
      * stack. This should only be called after the request has started. Note
      * that this call might block if there isn't any more data to be read.
      * Since byteBuffer is passed to the UrlRequest, it must be a direct
      * ByteBuffer.
      */
     void getMoreData(ByteBuffer byteBuffer) throws IOException {
@@ skipping 181 matching lines @@
             // Strips Content-Encoding response header. See crbug.com/592700.
             if (!entry.getKey().equalsIgnoreCase("Content-Encoding")) {
                 mResponseHeadersList.add(
                         new AbstractMap.SimpleImmutableEntry<String, String>(entry));
             }
         }
         mResponseHeadersList = Collections.unmodifiableList(mResponseHeadersList);
         return mResponseHeadersList;
     }
 }