Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2030873002: Mojo C++ bindings: rename ArrayValidateParams for clarity (Closed)

Created:
4 years, 6 months ago by tibell
Modified:
4 years, 6 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cc-enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: rename ArrayValidateParams for clarity BUG=616649 TESTED=mojo/edk/test:mojo_public_bindings_unittests Committed: https://crrev.com/34b7a3f0a2b1266cfa37fcc8a18a87ddfc623bec Cr-Commit-Position: refs/heads/master@{#397961}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address review comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -103 lines) Patch
M mojo/public/cpp/bindings/lib/array_internal.h View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/lib/map_data_internal.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/map_serialization.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/native_struct_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/native_struct_serialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/validate_params.h View 1 4 chunks +14 lines, -15 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/array_common_test.h View 5 chunks +9 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/tests/map_unittest.cc View 1 3 chunks +12 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M mojo/public/cpp/bindings/tests/union_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/tests/wtf_types_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl View 1 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 2 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
tibell
4 years, 6 months ago (2016-06-02 06:36:43 UTC) #2
yzshen1
https://codereview.chromium.org/2030873002/diff/1/mojo/public/cpp/bindings/lib/map_serialization.h File mojo/public/cpp/bindings/lib/map_serialization.h (right): https://codereview.chromium.org/2030873002/diff/1/mojo/public/cpp/bindings/lib/map_serialization.h#newcode110 mojo/public/cpp/bindings/lib/map_serialization.h:110: // We don't need an ContainerValidateParams instance for key ...
4 years, 6 months ago (2016-06-02 19:57:03 UTC) #3
tibell
PTAL https://codereview.chromium.org/2030873002/diff/1/mojo/public/cpp/bindings/lib/map_serialization.h File mojo/public/cpp/bindings/lib/map_serialization.h (right): https://codereview.chromium.org/2030873002/diff/1/mojo/public/cpp/bindings/lib/map_serialization.h#newcode110 mojo/public/cpp/bindings/lib/map_serialization.h:110: // We don't need an ContainerValidateParams instance for ...
4 years, 6 months ago (2016-06-03 00:01:31 UTC) #4
yzshen1
lgtm
4 years, 6 months ago (2016-06-03 01:26:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030873002/40001
4 years, 6 months ago (2016-06-06 00:48:38 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-06 02:08:29 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 02:11:01 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/34b7a3f0a2b1266cfa37fcc8a18a87ddfc623bec
Cr-Commit-Position: refs/heads/master@{#397961}

Powered by Google App Engine
This is Rietveld 408576698