mojo/public/cpp/bindings/tests/map_unittest.cc - Issue 2030873002: Mojo C++ bindings: rename ArrayValidateParams for clarity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/map_unittest.cc

Issue 2030873002: Mojo C++ bindings: rename ArrayValidateParams for clarity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cc-enums

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/array_common_test.h ('k') | mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/map_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/map_unittest.cc b/mojo/public/cpp/bindings/tests/map_unittest.cc

index 547960b28d1d10b4caad7db80ef54572ee4a281f..9962c59497615c3a2eda5cbf31e7af25c316efd0 100644

--- a/mojo/public/cpp/bindings/tests/map_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/map_unittest.cc

@@ -23,7 +23,7 @@ namespace test {

namespace {

using mojo::internal::Array_Data;

-using mojo::internal::ArrayValidateParams;

+using mojo::internal::ContainerValidateParams;

using mojo::internal::FixedBufferForTesting;

using mojo::internal::Map_Data;

using mojo::internal::String_Data;

@@ -299,10 +299,10 @@ TEST_F(MapTest, ArrayOfMap) {

array, &context);

FixedBufferForTesting buf(size);

Array_Data<Map_Data<int32_t, int8_t>*>* data;

- ArrayValidateParams validate_params(

- 0, false, new ArrayValidateParams(

- new ArrayValidateParams(0, false, nullptr),

- new ArrayValidateParams(0, false, nullptr)));

+ ContainerValidateParams validate_params(

+ 0, false, new ContainerValidateParams(

+ new ContainerValidateParams(0, false, nullptr),

+ new ContainerValidateParams(0, false, nullptr)));

mojo::internal::Serialize<Array<Map<int32_t, int8_t>>>(

array, &buf, &data, &validate_params, &context);

@@ -328,12 +328,13 @@ TEST_F(MapTest, ArrayOfMap) {

array, &context);

FixedBufferForTesting buf(size);

Array_Data<Map_Data<String_Data*, Array_Data<bool>*>*>* data;

- ArrayValidateParams validate_params(

- 0, false, new ArrayValidateParams(

- new ArrayValidateParams(

- 0, false, new ArrayValidateParams(0, false, nullptr)),

- new ArrayValidateParams(

- 0, false, new ArrayValidateParams(0, false, nullptr))));

+ ContainerValidateParams validate_params(

+ 0, false,

+ new ContainerValidateParams(

+ 0, false, new ContainerValidateParams(0, false, nullptr)),

+ new ContainerValidateParams(

+ 0, false, new ContainerValidateParams(0, false, nullptr))));

mojo::internal::Serialize<Array<Map<String, Array<bool>>>>(

array, &buf, &data, &validate_params, &context);