Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2030803003: [css-grid] Get rid of AvailableSpaceType enum (Closed)

Created:
4 years, 6 months ago by Manuel Rego
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Manuel Rego, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Get rid of AvailableSpaceType enum The AvailableSpaceType enum was somehow duplicated with the GridTrackSizing::SizingOperation one. AvailableSpaceType was always AvailableSpaceIndefinite when the SizingOperation is IntrinsicSizeComputation; and the other way around, always AvailableSpaceDefinite when the SizingOperation is TrackSizing. So, we can get rid of AvailableSpaceType enum, and only use SizingOperation to know if we're computing or not the intrinsic sizes of the grid container. No new tests, no change of behavior. BUG=616716 Committed: https://crrev.com/0582562513e9373d43f4ed2bbf9d644bb69347f5 Cr-Commit-Position: refs/heads/master@{#397431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutGrid.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 6 chunks +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Manuel Rego
4 years, 6 months ago (2016-06-02 14:03:33 UTC) #2
svillar
lgtm
4 years, 6 months ago (2016-06-02 14:13:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030803003/1
4 years, 6 months ago (2016-06-02 14:16:06 UTC) #5
eae
LGTM
4 years, 6 months ago (2016-06-02 14:29:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 16:05:41 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 16:07:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0582562513e9373d43f4ed2bbf9d644bb69347f5
Cr-Commit-Position: refs/heads/master@{#397431}

Powered by Google App Engine
This is Rietveld 408576698