Issue 203078: Escape ampersands in web view text selection for right click context menu so ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203078: Escape ampersands in web view text selection for right click context menu so ... (Closed)

Created:
11 years, 3 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher, mattm

CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Escape ampersands in web view text selection for right click context menu so that they don't show up as mnemonics. Also escape underscores in gtk menus so they don't show up as mnemonics (we use ampersands to match windows). BUG=14587 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26401

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -8 lines)			Patch
	M	chrome/browser/tab_contents/render_view_context_menu.cc	View		2 chunks	+25 lines, -6 lines	0 comments	Download
	M	chrome/common/gtk_util.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mattm

11 years, 3 months ago (2009-09-16 01:07:21 UTC) #2

lgtm

On 2009/09/16 00:50:39, Evan Stade wrote:
> we don't rely on _ anywhere for mnemonics, do we?


Not that I know of

Expand Messages | Collapse Messages