Escape ampersands in web view text selection for right click context menu so ...

chrome/browser/tab_contents/render_view_context_menu.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
 
 #include "app/l10n_util.h"
 #include "base/clipboard.h"
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 13 matching lines @@
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/platform_util.h"
 #include "chrome/common/pref_service.h"
 #include "chrome/common/url_constants.h"
 #include "grit/generated_resources.h"
 #include "net/base/escape.h"
 #include "net/base/net_util.h"
 #include "webkit/glue/media_player_action.h"
 
+namespace {
+
+string16 EscapeAmpersands(const string16& text) {
+  string16 ret;
+  ret.reserve(text.length() * 2);
+  for (string16::const_iterator i = text.begin();
+       i != text.end(); ++i) {
+    // The escape for an ampersand is two ampersands.
+    if ('&' == *i)
+      ret.push_back(*i);
+
+    ret.push_back(*i);
+  }
+
+  return ret;
+}
+
+}  // namespace
+
 RenderViewContextMenu::RenderViewContextMenu(
     TabContents* tab_contents,
     const ContextMenuParams& params)
     : params_(params),
       source_tab_contents_(tab_contents),
       profile_(tab_contents->profile()) {
 }
 
 RenderViewContextMenu::~RenderViewContextMenu() {
 }
@@ skipping 138 matching lines @@
 
 void RenderViewContextMenu::AppendCopyItem() {
   AppendMenuItem(IDS_CONTENT_CONTEXT_COPY);
 }
 
 void RenderViewContextMenu::AppendSearchProvider() {
   DCHECK(profile_);
   const TemplateURL* const default_provider =
       profile_->GetTemplateURLModel()->GetDefaultSearchProvider();
   if (default_provider != NULL) {
-    std::wstring selection_text =
-        l10n_util::TruncateString(params_.selection_text, 50);
+    string16 selection_text = EscapeAmpersands(WideToUTF16(
+        l10n_util::TruncateString(params_.selection_text, 50)));
     if (!selection_text.empty()) {
-      string16 label(WideToUTF16(
-          l10n_util::GetStringF(IDS_CONTENT_CONTEXT_SEARCHWEBFOR,
-                                default_provider->short_name(),
-                                selection_text)));
+      string16 label(l10n_util::GetStringFUTF16(
+          IDS_CONTENT_CONTEXT_SEARCHWEBFOR,
+          WideToUTF16(default_provider->short_name()),
+          selection_text));
       AppendMenuItem(IDS_CONTENT_CONTEXT_SEARCHWEBFOR, label);
     }
   }
 }
 
 void RenderViewContextMenu::AppendEditableItems() {
   // Append Dictionary spell check suggestions.
   for (size_t i = 0; i < params_.dictionary_suggestions.size() &&
        IDC_SPELLCHECK_SUGGESTION_0 + i <= IDC_SPELLCHECK_SUGGESTION_LAST;
        ++i) {
@@ skipping 596 matching lines @@
   WriteTextToClipboard(UTF8ToUTF16(utf8_text));
   DidWriteURLToClipboard(utf8_text);
 }
 
 void RenderViewContextMenu::MediaPlayerActionAt(
     int x,
     int y,
     const MediaPlayerAction& action) {
   source_tab_contents_->render_view_host()->MediaPlayerActionAt(x, y, action);
 }