Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerBridge.java

Issue 2030773002: Add unit tests for the Background Scheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable flaky test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerBridge.java
index aaf8ab98679adbaaa455989eb55112c2c0a3b65b..6f785286002d36bb46264c968414c894ac38da48 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerBridge.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.offlinepages;
+import org.chromium.base.Callback;
import org.chromium.base.ContextUtils;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
@@ -15,14 +16,6 @@ import org.chromium.base.annotations.JNINamespace;
*/
@JNINamespace("offline_pages::android")
public class BackgroundSchedulerBridge {
- /**
- * Callback used to determine when request processing is done.
- */
- public interface ProcessingDoneCallback {
- @CalledByNative("ProcessingDoneCallback")
- void onProcessingDone(boolean result);
- }
-
// Starts processing of one or more queued background requests.
// Returns whether processing was started and that caller should
// expect a callback (once processing has completed or terminated).
@@ -31,7 +24,7 @@ public class BackgroundSchedulerBridge {
// not receive a callback.
// TODO(dougarnett): consider adding policy check api to let caller
// separately determine if not allowed by policy.
- public static boolean startProcessing(ProcessingDoneCallback callback) {
+ public static boolean startProcessing(Callback<Boolean> callback) {
return nativeStartProcessing(callback);
}
@@ -45,5 +38,6 @@ public class BackgroundSchedulerBridge {
BackgroundScheduler.unschedule(ContextUtils.getApplicationContext());
}
- private static native boolean nativeStartProcessing(ProcessingDoneCallback callback);
+ private static native boolean nativeStartProcessing(
+ Callback<Boolean> callback);
}

Powered by Google App Engine
This is Rietveld 408576698