Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2216)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java

Issue 2030773002: Add unit tests for the Background Scheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable flaky test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java
index dde5dba157bc8f7871c5f8c6b7af8515fbeb9954..864f4751ef236e833552db6a9fb08d84e7f4cc8c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundScheduler.java
@@ -17,8 +17,6 @@ import org.chromium.chrome.browser.ChromeBackgroundService;
* The background scheduler class is for setting GCM Network Manager tasks.
*/
public class BackgroundScheduler {
- /** Bundle key for the timestamp in milliseconds when the request started. */
- public static final String DATE_TAG = "Date";
private static final long ONE_WEEK_IN_SECONDS = 60 * 60 * 24 * 7;
/**
@@ -28,13 +26,11 @@ public class BackgroundScheduler {
// Get the GCM Network Scheduler.
GcmNetworkManager gcmNetworkManager = GcmNetworkManager.getInstance(context);
- // TODO(petewil): Move the bundle packing and unpacking into a new SchedulerBridge
- // class which can be mocked, and calls the static BackgroundSchdeulerBridge.
// TODO(petewil): Add the triggering conditions into the argument bundle.
// Triggering conditions will include network state and charging requirements, maybe
// also battery percentage.
Bundle taskExtras = new Bundle();
- taskExtras.putLong(DATE_TAG, System.currentTimeMillis());
+ TaskExtrasPacker.packTimeInBundle(taskExtras);
Task task = new OneoffTask.Builder()
.setService(ChromeBackgroundService.class)
@@ -44,7 +40,6 @@ public class BackgroundScheduler {
.setRequiredNetwork(Task.NETWORK_STATE_CONNECTED)
.setRequiresCharging(false)
.setExtras(taskExtras)
- .setPersisted(true)
.build();
gcmNetworkManager.schedule(task);

Powered by Google App Engine
This is Rietveld 408576698