Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: scripts/slave/recipe_modules/chromium_android/chromium_config.py

Issue 2030713004: Refactor chromium.perf recipe configs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@2-refactorr
Patch Set: FYI configs. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/chromium_config.py
diff --git a/scripts/slave/recipe_modules/chromium_android/chromium_config.py b/scripts/slave/recipe_modules/chromium_android/chromium_config.py
index 44bfaa6c324e1b20a7b617ad00857ff1093be106..d72a04d14b36fbe38bb0703005955321cc226ef1 100644
--- a/scripts/slave/recipe_modules/chromium_android/chromium_config.py
+++ b/scripts/slave/recipe_modules/chromium_android/chromium_config.py
@@ -196,14 +196,6 @@ def incremental_coverage_builder_tests(c):
def non_device_wipe_provisioning(c):
pass
-# TODO(zty): figure out what perf builder really wants and use that instead.
-# e.g. official
-@CONFIG_CTX(includes=['main_builder'])
-def perf(c):
- gyp_defs = c.gyp_env.GYP_DEFINES
- gyp_defs['branding'] = 'Chrome'
- gyp_defs['buildtype'] = 'Official'
-
@CONFIG_CTX(includes=['main_builder'])
def cast_builder(c):
c.gyp_env.GYP_DEFINES['chromecast'] = 1

Powered by Google App Engine
This is Rietveld 408576698