scripts/slave/recipe_modules/chromium/config.py - Issue 2030713004: Refactor chromium.perf recipe configs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 2030713004: Refactor chromium.perf recipe configs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@2-refactorr

Patch Set: FYI configs. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_android/chromium_config.py » ('j') | scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Builder.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium/config.py

diff --git a/scripts/slave/recipe_modules/chromium/config.py b/scripts/slave/recipe_modules/chromium/config.py

index 2dd48cf46ae74e9bc3c75dfba252f8cf263954e1..65b77eeef64bb5a8f4185f136f5c69c92411d5b9 100644

--- a/scripts/slave/recipe_modules/chromium/config.py

+++ b/scripts/slave/recipe_modules/chromium/config.py

@@ -781,17 +781,15 @@ def v8_slow_dchecks(c):

def v8_verify_heap(c):

c.gyp_env.GYP_DEFINES['v8_enable_verify_heap'] = 1

-@config_ctx()

+@config_ctx(includes=['chromium', 'official', 'mb'])

def chromium_perf(c):

c.clobber_before_runhooks = False

-@config_ctx()

-def chromium_perf_fyi(c):

- c.clobber_before_runhooks = False

- if c.HOST_PLATFORM == 'win':

- c.compile_py.compiler = None

- c.compile_py.goma_dir = None

- c.gyp_env.GYP_DEFINES['use_goma'] = 0

+@config_ctx(includes=['chromium_perf', 'goma_hermetic_fallback'])

+def tryserver_chromium_perf(c):

+ # Bisects may build using old toolchains, so goma_hermetic_fallback is

+ # required. See https://codereview.chromium.org/1015633002

+ pass

@config_ctx(includes=['chromium_clang'])

def cast_linux(c):