Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2030523003:
re-enable PCv2 on non-ref Android (Closed)
|
Created:
4 years, 6 months ago by kouhei (in TOK) Modified:
4 years, 6 months ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionre-enable PCv2 on non-ref Android
BUG=615178
Committed: https://crrev.com/b34eeae48ba79e80c4ec601922459d77af905f5a
Cr-Commit-Position: refs/heads/master@{#397120}
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
Description was changed from ========== re-enable PCv2 on non-ref Android BUG=615178 ========== to ========== re-enable PCv2 on non-ref Android BUG=615178 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
kouhei@chromium.org changed reviewers: + nednguyen@google.com
ptal
The CQ bit was checked by kouhei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030523003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
Description was changed from ========== re-enable PCv2 on non-ref Android BUG=615178 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== re-enable PCv2 on non-ref Android BUG=615178 ==========
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030523003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by nednguyen@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030523003/1
Message was sent while issue was closed.
Description was changed from ========== re-enable PCv2 on non-ref Android BUG=615178 ========== to ========== re-enable PCv2 on non-ref Android BUG=615178 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== re-enable PCv2 on non-ref Android BUG=615178 ========== to ========== re-enable PCv2 on non-ref Android BUG=615178 Committed: https://crrev.com/b34eeae48ba79e80c4ec601922459d77af905f5a Cr-Commit-Position: refs/heads/master@{#397120} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b34eeae48ba79e80c4ec601922459d77af905f5a Cr-Commit-Position: refs/heads/master@{#397120}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2030713005/ by zhenw@chromium.org. The reason for reverting is: page_cycler_v2.typical_25 fails on Android perf bot. See http://crbug.com/616781.
Message was sent while issue was closed.
On 2016/06/03 01:42:08, Zhen Wang wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2030713005/ by mailto:zhenw@chromium.org. > > The reason for reverting is: page_cycler_v2.typical_25 fails on Android perf > bot. See http://crbug.com/616781. Based on the discussion with Ned, we decided to disable the test on Android One and Nexus 5X only, and not revert the original CL. See https://codereview.chromium.org/2030243003/ |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
