Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: tools/perf/benchmarks/page_cycler_v2.py

Issue 2030523003: re-enable PCv2 on non-ref Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler_v2.py
diff --git a/tools/perf/benchmarks/page_cycler_v2.py b/tools/perf/benchmarks/page_cycler_v2.py
index 9e0d73d52c81cc822b1a91137df112d755934a97..3fd81079ed452bb171d3266f256abe908ef47923 100644
--- a/tools/perf/benchmarks/page_cycler_v2.py
+++ b/tools/perf/benchmarks/page_cycler_v2.py
@@ -28,7 +28,7 @@ class _PageCyclerV2(perf_benchmark.PerfBenchmark):
return tbm_options
-@benchmark.Disabled('win', 'android') # crbug.com/615178
+@benchmark.Disabled('win') # crbug.com/615178
class PageCyclerV2Typical25(_PageCyclerV2):
"""Page load time benchmark for a 25 typical web pages.
@@ -41,6 +41,11 @@ class PageCyclerV2Typical25(_PageCyclerV2):
def Name(cls):
return 'page_cycler_v2.typical_25'
+ @classmethod
+ def ShouldDisable(cls, possible_browser): # crbug.com/615178
+ return (possible_browser.browser_type == 'reference' and
+ possible_browser.platform.GetOSName() == 'android')
+
def CreateStorySet(self, options):
return page_sets.Typical25PageSet(run_no_page_interactions=True,
cache_temperatures=[
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698