Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2030443003: Make ScriptCustomeElementDefinition class to hold ScriptState (Closed)

Created:
4 years, 6 months ago by yosin_UTC9
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ScriptCustomeElementDefinition class to hold ScriptState This patch introduces |m_scriptState| member variable to |ScriptCustomeElementDefinition| class to hold |ScriptState| pointer, to return |ScriptValue| for JavaScript's constructor, prototype, callbacks, etc, on the context where JavaScript values created. This patch is a preparation of crrev.com/1994093002, introduce |CustomElementRegistry#get()| method. BUG=594918 TEST=n/a; no behavior changes Committed: https://crrev.com/9beaf25c2880e2682c86811743f95e0518c596bf Cr-Commit-Position: refs/heads/master@{#397069}

Patch Set 1 : 2016-06-01T12:59:29 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL This patch is spawn from crrev.com/1994093002, introduce |CustomElementRegistry#get()| method.
4 years, 6 months ago (2016-06-01 04:08:53 UTC) #3
haraken
LGTM
4 years, 6 months ago (2016-06-01 04:16:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030443003/1
4 years, 6 months ago (2016-06-01 04:44:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 05:46:27 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 05:47:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9beaf25c2880e2682c86811743f95e0518c596bf
Cr-Commit-Position: refs/heads/master@{#397069}

Powered by Google App Engine
This is Rietveld 408576698