third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp - Issue 2030443003: Make ScriptCustomeElementDefinition class to hold ScriptState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

Issue 2030443003: Make ScriptCustomeElementDefinition class to hold ScriptState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-06-01T12:59:29 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

index d0d3bd051180dce7ef6a8ad89f2a005361ff7fe8..879fac4ecdfd1b38f444b0883ebaad761c1bde21 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

@@ -109,6 +109,7 @@ ScriptCustomElementDefinition::ScriptCustomElementDefinition(

const v8::Local<v8::Object>& constructor,

const v8::Local<v8::Object>& prototype)

: CustomElementDefinition(descriptor)

+ , m_scriptState(scriptState)

, m_constructor(scriptState->isolate(), constructor)

, m_prototype(scriptState->isolate(), prototype)

{

@@ -119,18 +120,16 @@ ScriptCustomElementDefinition::ScriptCustomElementDefinition(

m_prototype.setPhantom();

}

-v8::Local<v8::Object> ScriptCustomElementDefinition::constructor(

- ScriptState* scriptState) const

+v8::Local<v8::Object> ScriptCustomElementDefinition::constructor() const

{

DCHECK(!m_constructor.isEmpty());

- return m_constructor.newLocal(scriptState->isolate());

+ return m_constructor.newLocal(m_scriptState->isolate());

}

-v8::Local<v8::Object> ScriptCustomElementDefinition::prototype(

- ScriptState* scriptState) const

+v8::Local<v8::Object> ScriptCustomElementDefinition::prototype() const

{

DCHECK(!m_prototype.isEmpty());

- return m_prototype.newLocal(scriptState->isolate());

+ return m_prototype.newLocal(m_scriptState->isolate());

}

} // namespace blink