Issue 203043002: Fix "unreachable code" warnings (MSVC warning 4702), misc. edition.

Issue 203043002: Fix "unreachable code" warnings (MSVC warning 4702), misc. edition. (Closed)

Created:
6 years, 9 months ago by Peter Kasting

Modified:
6 years, 9 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, tzik, haitaol+watch_chromium.org, nhiroki, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, kinuko+watch, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix "unreachable code" warnings (MSVC warning 4702), misc. edition. This CL covers top-level directories that only had one or two modified files. BUG=346399 TEST=none R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257705

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -112 lines)			Patch
M	cc/output/output_surface.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	cloud_print/service/win/chrome_launcher.cc	View		4 chunks	+12 lines, -17 lines	0 comments	Download
M	components/translate/language_detection/language_detection_util.cc	View		1 chunk	+15 lines, -12 lines	0 comments	Download
M	courgette/disassembler_elf_32_arm.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	device/bluetooth/bluetooth_adapter_factory.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	extensions/common/extension_paths.cc	View		1 chunk	+12 lines, -20 lines	0 comments	Download
M	gpu/config/gpu_info_collector_win.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	media/filters/ffmpeg_demuxer.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer_unittest.cc	View		3 chunks	+6 lines, -9 lines	0 comments	Download
M	sync/syncable/model_type.cc	View		3 chunks	+2 lines, -27 lines	2 comments	Download
M	tools/gn/gn_main.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/browser/fileapi/isolated_context.cc	View		1 chunk	+4 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM w/ question: https://codereview.chromium.org/203043002/diff/20001/sync/syncable/model_type.cc File sync/syncable/model_type.cc (right): https://codereview.chromium.org/203043002/diff/20001/sync/syncable/model_type.cc#newcode138 sync/syncable/model_type.cc:138: DCHECK(ProtocolTypes().Has(model_type)) Aren't you tossing out the ...

6 years, 9 months ago (2014-03-18 08:07:30 UTC) #2

Peter Kasting

https://codereview.chromium.org/203043002/diff/20001/sync/syncable/model_type.cc File sync/syncable/model_type.cc (right): https://codereview.chromium.org/203043002/diff/20001/sync/syncable/model_type.cc#newcode138 sync/syncable/model_type.cc:138: DCHECK(ProtocolTypes().Has(model_type)) On 2014/03/18 08:07:30, darin wrote: > Aren't you ...

6 years, 9 months ago (2014-03-18 18:59:15 UTC) #3

Peter Kasting

6 years, 9 months ago (2014-03-18 19:04:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r257705 (presubmit successful).

Expand Messages | Collapse Messages