Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: extensions/common/extension_paths.cc

Issue 203043002: Fix "unreachable code" warnings (MSVC warning 4702), misc. edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/extension_paths.h" 5 #include "extensions/common/extension_paths.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 9
10 namespace extensions { 10 namespace extensions {
11 11
12 bool PathProvider(int key, base::FilePath* result) { 12 bool PathProvider(int key, base::FilePath* result) {
13 switch (key) { 13 if (key != DIR_TEST_DATA)
14 case DIR_TEST_DATA: { 14 return false;
15 base::FilePath cur; 15 base::FilePath cur;
16 if (!PathService::Get(base::DIR_SOURCE_ROOT, &cur)) 16 if (!PathService::Get(base::DIR_SOURCE_ROOT, &cur))
17 return false; 17 return false;
18 cur = cur.Append(FILE_PATH_LITERAL("extensions")); 18 cur = cur.Append(FILE_PATH_LITERAL("extensions"));
19 cur = cur.Append(FILE_PATH_LITERAL("test")); 19 cur = cur.Append(FILE_PATH_LITERAL("test"));
20 cur = cur.Append(FILE_PATH_LITERAL("data")); 20 cur = cur.Append(FILE_PATH_LITERAL("data"));
21 if (!base::PathExists(cur)) // we don't want to create this 21 if (!base::PathExists(cur)) // we don't want to create this
22 return false; 22 return false;
23 23 *result = cur;
24 *result = cur; 24 return true;
25 return true;
26 break;
27 }
28 default:
29 return false;
30 }
31
32 return false;
33 } 25 }
34 26
35 // This cannot be done as a static initializer sadly since Visual Studio will 27 // This cannot be done as a static initializer sadly since Visual Studio will
36 // eliminate this object file if there is no direct entry point into it. 28 // eliminate this object file if there is no direct entry point into it.
37 void RegisterPathProvider() { 29 void RegisterPathProvider() {
38 PathService::RegisterProvider(PathProvider, PATH_START, PATH_END); 30 PathService::RegisterProvider(PathProvider, PATH_START, PATH_END);
39 } 31 }
40 32
41 } // namespace extensions 33 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698