Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2030423002: Removing SAS gyp variables since they are no longer used by Chromoting. (Closed)

Created:
4 years, 6 months ago by joedow
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sas_be_gone
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing SAS gyp variables since they are no longer used by Chromoting. Chromoting no longer relies on the sas.dll so we can clean up some of the build files and remove these variables. BUG= Committed: https://crrev.com/de1387d31ef6fffe415c947ce3af245882f71fcf Cr-Commit-Position: refs/heads/master@{#398057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M build/all.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
M build/common.gypi View 3 chunks +0 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
joedow
Can you take a look at some clean-up I've done in the top level build ...
4 years, 6 months ago (2016-06-03 18:15:53 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-04 22:51:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030423002/1
4 years, 6 months ago (2016-06-06 16:26:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 17:47:39 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 17:48:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de1387d31ef6fffe415c947ce3af245882f71fcf
Cr-Commit-Position: refs/heads/master@{#398057}

Powered by Google App Engine
This is Rietveld 408576698