Limit tracked values in long running gmail benchmarks to V8 specific

Limit tracked values in long running gmail benchmarks to V8 specific
values and the overall renderer memory stats.

BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/b85904016ad11c2b2712cad3b545eab6e2e4c693
Cr-Commit-Position: refs/heads/master@{#398060}

[ulan, 2016-06-03 11:05:28]

Description was changed from

==========
Limit tracked values in long running gmail benchmarks to V8 specific
values and the overall renderer memory stats.

BUG=617117
==========

to

==========
Limit tracked values in long running gmail benchmarks to V8 specific
values and the overall renderer memory stats.

BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[ulan, 2016-06-03 11:11:31]

ulan@chromium.org changed reviewers:
+ petrcermak@chromium.org

[ulan, 2016-06-03 11:11:31]

PTAL.

As we agreed I am filtering out non-V8 values.

But I am leaving the overall renderer memory stats (24 values) to catch renderer
memory regressions outside V8 heap. Is it OK?

I will open a separate bug to add alerts for these memory stats.

[petrcermak, 2016-06-03 11:25:28]

petrcermak@chromium.org changed reviewers:
+ sullivan@chromium.org

[petrcermak, 2016-06-03 11:25:28]

Thanks for taking care of this so quickly.

LGTM with one comment, but let's WAIT UNTIL MONDAY before landing this (so that
there's enough time for people to reply to my previous email).

+sullivan for owner stamp

Thanks,
Petr

https://codereview.chromium.org/2030343002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory_infra.py (right):

https://codereview.chromium.org/2030343002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory_infra.py:169:
'memory_chrome_renderer_vmstats_overall' in value.name)
The value name is now "memory:chrome:renderer:vmstats:overall:*". I suggest you
change this to:

return 'v8' in value.name or 'vmstats:overall' in value.name

[ulan, 2016-06-03 11:34:30]

I'll wait until Monday.
 
> return 'v8' in value.name or 'vmstats:overall' in value.name
Thanks! I will use 'renderer:vmstats:overall' in value.name to exclude the
browser process and GPU (unless anyone objects in the email thread).

[petrcermak, 2016-06-03 11:55:56]

https://codereview.chromium.org/2030343002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory_infra.py (right):

https://codereview.chromium.org/2030343002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory_infra.py:169:
'memory_chrome_renderer_vmstats_overall' in value.name)
On 2016/06/03 11:25:28, petrcermak wrote:
> The value name is now "memory:chrome:renderer:vmstats:overall:*". I suggest
you
> change this to:
> 
> return 'v8' in value.name or 'vmstats:overall' in value.name

In that case, you might also want to change 'v8' to 'renderer:subsystem:v8' for
symmetry (unless there are alerts on all:subsystem:v8).

[sullivan, 2016-06-03 20:35:43]

lgtm

Thanks for your help with this!

[petrcermak, 2016-06-06 09:45:17]

https://codereview.chromium.org/2030343002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory_infra.py (right):

https://codereview.chromium.org/2030343002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory_infra.py:169:
'memory_chrome_renderer_vmstats_overall' in value.name)
On 2016/06/03 11:55:56, petrcermak wrote:
> On 2016/06/03 11:25:28, petrcermak wrote:
> > The value name is now "memory:chrome:renderer:vmstats:overall:*". I suggest
> you
> > change this to:
> > 
> > return 'v8' in value.name or 'vmstats:overall' in value.name
> 
> In that case, you might also want to change 'v8' to 'renderer:subsystem:v8'
for
> symmetry (unless there are alerts on all:subsystem:v8).

Ping on this comment.

[ulan, 2016-06-06 10:49:38]

On 2016/06/06 09:45:17, petrcermak wrote:
>
https://codereview.chromium.org/2030343002/diff/1/tools/perf/benchmarks/memor...
> File tools/perf/benchmarks/memory_infra.py (right):
> 
>
https://codereview.chromium.org/2030343002/diff/1/tools/perf/benchmarks/memor...
> tools/perf/benchmarks/memory_infra.py:169:
> 'memory_chrome_renderer_vmstats_overall' in value.name)
> On 2016/06/03 11:55:56, petrcermak wrote:
> > On 2016/06/03 11:25:28, petrcermak wrote:
> > > The value name is now "memory:chrome:renderer:vmstats:overall:*". I
suggest
> > you
> > > change this to:
> > > 
> > > return 'v8' in value.name or 'vmstats:overall' in value.name
> > 
> > In that case, you might also want to change 'v8' to 'renderer:subsystem:v8'
> for
> > symmetry (unless there are alerts on all:subsystem:v8).
> 
> Ping on this comment.

Done. Note that we also have time values that contain 'v8', so I had to add an
explicit check for memory values.

[petrcermak, 2016-06-06 11:24:15]

On 2016/06/06 10:49:38, ulan wrote:
> On 2016/06/06 09:45:17, petrcermak wrote:
> >
>
https://codereview.chromium.org/2030343002/diff/1/tools/perf/benchmarks/memor...
> > File tools/perf/benchmarks/memory_infra.py (right):
> > 
> >
>
https://codereview.chromium.org/2030343002/diff/1/tools/perf/benchmarks/memor...
> > tools/perf/benchmarks/memory_infra.py:169:
> > 'memory_chrome_renderer_vmstats_overall' in value.name)
> > On 2016/06/03 11:55:56, petrcermak wrote:
> > > On 2016/06/03 11:25:28, petrcermak wrote:
> > > > The value name is now "memory:chrome:renderer:vmstats:overall:*". I
> suggest
> > > you
> > > > change this to:
> > > > 
> > > > return 'v8' in value.name or 'vmstats:overall' in value.name
> > > 
> > > In that case, you might also want to change 'v8' to
'renderer:subsystem:v8'
> > for
> > > symmetry (unless there are alerts on all:subsystem:v8).
> > 
> > Ping on this comment.
> 
> Done. Note that we also have time values that contain 'v8', so I had to add an
> explicit check for memory values.

Note that this WILL report memory:chrome:all:subsystem:v8:* but NOT
memory:chrome:all:vmstats:overall:*. Unless this asymmetry is intentional, I
would replace the whole method's body with simply:

return 'v8' in value.name or 'vmstats:overall' in value.name

Other than that, still LGTM.

Thanks,
Petr

[ulan, 2016-06-06 12:13:50]

> Note that this WILL report memory:chrome:all:subsystem:v8:* but NOT
> memory:chrome:all:vmstats:overall:*. Unless this asymmetry is intentional, I
> would replace the whole method's body with simply:

Thank you. That is a bug, I wanted to include
memory:chrome:renderer*(v8|vmstat)*.

Uploaded a new PS.

[petrcermak, 2016-06-06 12:16:13]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-06-06 12:16:14]

lgtm

[petrcermak, 2016-06-06 12:16:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org
Link to the patchset: https://codereview.chromium.org/2030343002/#ps80001
(title: "Fix to include memory:chrome:renderer:subsystem and
memory:chrome:renderer:vmstats")

[commit-bot: I haz the power, 2016-06-06 12:16:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2030343002/80001

[commit-bot: I haz the power, 2016-06-06 12:41:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 12:41:13]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[petrcermak, 2016-06-06 13:43:15]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-06-06 13:43:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2030343002/80001

[nednguyen, 2016-06-06 17:42:33]

On 2016/06/06 13:43:31, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/2030343002/80001

I would just remove "tryserver.chromium.perf:winx64_10_perf_cq" if it keeps
failing.

[petrcermak, 2016-06-06 17:49:46]

Description was changed from

==========
Limit tracked values in long running gmail benchmarks to V8 specific
values and the overall renderer memory stats.

BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
Limit tracked values in long running gmail benchmarks to V8 specific
values and the overall renderer memory stats.

BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[petrcermak, 2016-06-06 17:49:57]

The CQ bit was unchecked by petrcermak@chromium.org

[petrcermak, 2016-06-06 17:49:58]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-06-06 17:50:21]

The CQ bit was unchecked by petrcermak@chromium.org

[petrcermak, 2016-06-06 17:50:26]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-06-06 17:51:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2030343002/80001

[commit-bot: I haz the power, 2016-06-06 17:56:33]

Description was changed from

==========
Limit tracked values in long running gmail benchmarks to V8 specific
values and the overall renderer memory stats.

BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
Limit tracked values in long running gmail benchmarks to V8 specific
values and the overall renderer memory stats.

BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[commit-bot: I haz the power, 2016-06-06 17:56:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-06 17:58:09]

Description was changed from

==========
Limit tracked values in long running gmail benchmarks to V8 specific
values and the overall renderer memory stats.

BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
Limit tracked values in long running gmail benchmarks to V8 specific
values and the overall renderer memory stats.

BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/b85904016ad11c2b2712cad3b545eab6e2e4c693
Cr-Commit-Position: refs/heads/master@{#398060}
==========

[commit-bot: I haz the power, 2016-06-06 17:58:10]

Patchset 5 (id:??) landed as
https://crrev.com/b85904016ad11c2b2712cad3b545eab6e2e4c693
Cr-Commit-Position: refs/heads/master@{#398060}