Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: tools/perf/benchmarks/memory_infra.py

Issue 2030343002: Limit tracked values in long running gmail benchmarks to V8 specific (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix to include memory:chrome:renderer:subsystem and memory:chrome:renderer:vmstats Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/memory_infra.py
diff --git a/tools/perf/benchmarks/memory_infra.py b/tools/perf/benchmarks/memory_infra.py
index df186b399a7515d732b8dd8a44d6fbee7fe93bc1..c6d766ef86fbfba930d40b6bccf2251023f469f6 100644
--- a/tools/perf/benchmarks/memory_infra.py
+++ b/tools/perf/benchmarks/memory_infra.py
@@ -163,6 +163,13 @@ class _MemoryV8Benchmark(_MemoryInfra):
options.SetTimelineBasedMetric('v8AndMemoryMetrics')
return options
+ @classmethod
+ def ValueCanBeAddedPredicate(cls, value, _):
+ if 'memory:chrome' in value.name:
+ return ('renderer:subsystem:v8' in value.name or
+ 'renderer:vmstats:overall' in value.name)
+ return 'v8' in value.name
+
class MemoryLongRunningIdleGmail(_MemoryV8Benchmark):
"""Use (recorded) real world web sites and measure memory consumption
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698