Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2030023005: Disable AltSvc from insecure origin. (Closed)

Created:
4 years, 6 months ago by Bence
Modified:
4 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Disable AltSvc from insecure origin. * Do not parse Alt-Svc response on insecure connections, add regression test. * Do not follow in-memory Alt-Svc on insecure connections, add regression test. This CL has a shortcut: |enable_alt_svc_for_insecure_origin|, which is false in production but true in tests (except for the two regression tests). Adapting the existing tests is a lot of work, that will come in one or more follow-up CLs. TBR=rch@chromium.org BUG=615497 Review-Url: https://codereview.chromium.org/2026863002 Cr-Commit-Position: refs/heads/master@{#397097} (cherry picked from commit e3dd56f4d98843611954b84fa28c1e884594fd05) Committed: https://chromium.googlesource.com/chromium/src/+/44e83591c5ea7ee2eb03ac84ebb03cca574a900d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -2 lines) Patch
M net/http/http_network_session.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 2 chunks +100 lines, -0 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Bence
4 years, 6 months ago (2016-06-03 17:49:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
44e83591c5ea7ee2eb03ac84ebb03cca574a900d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698