Disable AltSvc from insecure origin.

Disable AltSvc from insecure origin.

* Do not parse Alt-Svc response on insecure connections, add regression test.
* Do not follow in-memory Alt-Svc on insecure connections, add regression test.

This CL has a shortcut: |enable_alt_svc_for_insecure_origin|, which is false in
production but true in tests (except for the two regression tests).  Adapting
the existing tests is a lot of work, that will come in one or more follow-up
CLs.

BUG=615497
Committed: https://crrev.com/e3dd56f4d98843611954b84fa28c1e884594fd05
Cr-Commit-Position: refs/heads/master@{#397097}

[Bence, 2016-05-31 20:57:55]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2016-05-31 20:57:56]

Ryan: PTAL.  Thank you.

[Ryan Hamilton, 2016-05-31 23:43:42]

lgtm

https://codereview.chromium.org/2026863002/diff/1/net/http/http_stream_factor...
File net/http/http_stream_factory_impl.cc (right):

https://codereview.chromium.org/2026863002/diff/1/net/http/http_stream_factor...
net/http/http_stream_factory_impl.cc:221: !original_url.SchemeIs("https"))
nit: I think this should probably have {}s since the if is more than one line.

https://codereview.chromium.org/2026863002/diff/1/net/quic/quic_network_trans...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/2026863002/diff/1/net/quic/quic_network_trans...
net/quic/quic_network_transaction_unittest.cc:266:
params_.enable_alternative_service_for_insecure_origins = true;
I'm surprised we have any of these left since I thought we didn't support
insecure quic.

[Bence, 2016-06-01 10:33:24]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-06-01 10:33:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026863002/1

[commit-bot: I haz the power, 2016-06-01 10:37:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-01 10:39:14]

Description was changed from

==========
Disable AltSvc from insecure origin.

* Do not parse Alt-Svc response on insecure connections, add regression test.
* Do not follow in-memory Alt-Svc on insecure connections, add regression test.

This CL has a shortcut: |enable_alt_svc_for_insecure_origin|, which is false in
production but true in tests (except for the two regression tests).  Adapting
the existing tests is a lot of work, that will come in one or more follow-up
CLs.

BUG=615497
==========

to

==========
Disable AltSvc from insecure origin.

* Do not parse Alt-Svc response on insecure connections, add regression test.
* Do not follow in-memory Alt-Svc on insecure connections, add regression test.

This CL has a shortcut: |enable_alt_svc_for_insecure_origin|, which is false in
production but true in tests (except for the two regression tests).  Adapting
the existing tests is a lot of work, that will come in one or more follow-up
CLs.

BUG=615497

Committed: https://crrev.com/e3dd56f4d98843611954b84fa28c1e884594fd05
Cr-Commit-Position: refs/heads/master@{#397097}
==========

[commit-bot: I haz the power, 2016-06-01 10:39:15]

Patchset 1 (id:??) landed as
https://crrev.com/e3dd56f4d98843611954b84fa28c1e884594fd05
Cr-Commit-Position: refs/heads/master@{#397097}

[Bence, 2016-06-01 10:54:38]

Thank you.

https://codereview.chromium.org/2026863002/diff/1/net/http/http_stream_factor...
File net/http/http_stream_factory_impl.cc (right):

https://codereview.chromium.org/2026863002/diff/1/net/http/http_stream_factor...
net/http/http_stream_factory_impl.cc:221: !original_url.SchemeIs("https"))
On 2016/05/31 23:43:42, Ryan Hamilton wrote:
> nit: I think this should probably have {}s since the if is more than one line.

Sorry, I missed this.  Will do in a follow-up.

https://codereview.chromium.org/2026863002/diff/1/net/quic/quic_network_trans...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/2026863002/diff/1/net/quic/quic_network_trans...
net/quic/quic_network_transaction_unittest.cc:266:
params_.enable_alternative_service_for_insecure_origins = true;
On 2016/05/31 23:43:42, Ryan Hamilton wrote:
> I'm surprised we have any of these left since I thought we didn't support
> insecure quic.

It's only SetAlternativeServicesWithScheme, should be easy to fix.